[debbugs-tracker] bug#26487: closed (Add antlr3)

[GNU bug Tracking System]

Your message dated Mon, 15 May 2017 23:21:25 +0200
with message-id <address@hidden>
and subject line Re: bug#26487: Add antlr3
has caused the debbugs.gnu.org bug report #26487,
regarding Add antlr3
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
26487: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26487
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Add antlr3 Date: Thu, 13 Apr 2017 22:46:13 +0200

Hi, here are patches to add antlr3, a parser generator.

* 0001-guix-ant-build-system-Add-src-dir-parameter.patch: adds a
  #:src-dir parameter to the ant-build-system, to change the source
  directory and possibly specify more than one directory.
* 0002-gnu-Add-antlr2.patch: Adds antlr2, an older version of antlr,
  that is required by antlr3 to generate some of its source files, and
  because parts of it is used by antlr3 (such as the CommonTree class).
* 0003-gnu-Add-stringtemplate3.patch: Adds stringtemplate3, a runtime
  requirement of antlr3. It is a library to generate strings using
  templates.
* 0004-gnu-Add-antlr3-and-stringtemplate4.patch: a big patch that adds
  antlr3 and stringtemplate4 (ST4). ST4 is a newer version of ST3, is a
  runtime dependency of antlr3 and needs antlr3 to generate some of its
  source files. antlr3 depends on ST4 too. I didn't find a way to split
  this patch further.

I wanted to package antlr4, but I'm still working on its dependencies
(antlr3 is one of them).

0001-guix-ant-build-system-Add-src-dir-parameter.patch
Description: Text Data

0002-gnu-Add-antlr2.patch
Description: Text Data

0003-gnu-Add-stringtemplate3.patch
Description: Text Data

0004-gnu-Add-antlr3-and-stringtemplate4.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#26487: Add antlr3
>
>
>
>
> Date: 
>
> Mon, 15 May 2017 23:21:25 +0200
>
>
>
>
> User-agent: 
>
> mu4e 0.9.18; emacs 25.2.1
>
>
>
>
> Hi Julien,
>
> thank you for tackling antlr!
>
> I saw that the patches have already been pushed, but here are a couple
> of comments anyway.
>
> * Please end all phases and snippets with “#t” or use (zero? …) when
>   the last thing is “system*”.
>
> * All Java packages should be prefixed with “java-”.
>
> * Please capitalise “Java” in descriptions.
>
> * When disabling tests, please always explain why.
>
> * Instead of copying from the ant-build-system you can reference build
>   phases directly.
>
> * Please use “with-directory-excursion” instead of multiple calls to
>   “chdir” when possible.
>
> * Please put comments before package variants that use a seemingly
>   arbitrary version or configuration.
>
> I’m going to make a couple of changes to your packages in the coming
> days as follow-up commits to address these issues.
>
> Thanks again!
>
> (Since the patches have been pushed already, I’m closing this bug.)
>
> --
> Ricardo
>
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
>
>
>
> --- End Message ---