[debbugs-tracker] bug#27225: closed ([PATCH] artwork: Use a descriptive name for the source directory.)

[GNU bug Tracking System]

Your message dated Wed, 7 Jun 2017 15:59:40 -0400
with message-id <address@hidden>
and subject line Re: bug#27225: [PATCH] artwork: Use a descriptive name for the 
source directory.
has caused the debbugs.gnu.org bug report #27225,
regarding [PATCH] artwork: Use a descriptive name for the source directory.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
27225: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27225
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] artwork: Use a descriptive name for the source directory.
>
>
>
>
> Date: 
>
> Sat,  3 Jun 2017 19:54:01 -0400
>
>
>
>
> * gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
> use the full commit hash when fetching.
> ---
>  gnu/artwork.scm | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/artwork.scm b/gnu/artwork.scm
> index 94c89143a..204845bd6 100644
> --- a/gnu/artwork.scm
> +++ b/gnu/artwork.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2014, 2015 Ludovic Courtès <address@hidden>
> +;;; Copyright © 2017 Leo Famulari <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -28,13 +29,15 @@
>  ;;; Code:
>  
>  (define %artwork-repository
> -  (origin
> -    (method git-fetch)
> -    (uri (git-reference
> -          (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
> -          (commit "6998d30")))
> -    (sha256
> -     (base32
> -      "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j"))))
> +  (let ((commit "6998d30425289b087c64f63e7415df2241e591db"))
> +    (origin
> +      (method git-fetch)
> +      (uri (git-reference
> +             (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
> +             (commit commit)))
> +      (file-name (string-append "guix-artwork-" (string-take commit 7) 
> "-checkout"))
> +      (sha256
> +       (base32
> +        "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j")))))
>  
>  ;;; artwork.scm ends here
> -- 
> 2.13.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#27225: [PATCH] artwork: Use a descriptive name for the source directory. Date: Wed, 7 Jun 2017 15:59:40 -0400 User-agent: Mutt/1.8.3 (2017-05-23)

On Wed, Jun 07, 2017 at 12:56:56PM +0300, Alex Kost wrote:
> Leo Famulari (2017-06-03 19:54 -0400) wrote:
> > * gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
> > use the full commit hash when fetching.

> > +      (file-name (string-append "guix-artwork-" (string-take commit 7) 
> > "-checkout"))
> 
> As for me, this line is too long, I would make it:
> 
>        (file-name (string-append "guix-artwork-" (string-take commit 7)
>                                  "-checkout"))

Oops! Fixed before pushing as 94db92f78ec9c849f9c8da05d4d35356909f9fbe.

signature.asc
Description: PGP signature

--- End Message ---