|
From: | GNU bug Tracking System |
Subject: | [debbugs-tracker] bug#27587: closed (25.1; in the dynamic modules api, env->free_global_ref doesn't free anything) |
Date: | Sun, 09 Jul 2017 22:18:02 +0000 |
Your message dated Sun, 09 Jul 2017 22:17:17 +0000 with message-id <address@hidden> and subject line Re: bug#27587: 25.1; in the dynamic modules api, env->free_global_ref doesn't free anything has caused the debbugs.gnu.org bug report #27587, regarding 25.1; in the dynamic modules api, env->free_global_ref doesn't free anything to be marked as done. (If you believe you have received this mail in error, please contact address@hidden) -- 27587: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27587 GNU Bug Tracking System Contact address@hidden with problems
--- Begin Message ---Subject: 25.1; in the dynamic modules api, env->free_global_ref doesn't free anything Date: Wed, 5 Jul 2017 08:43:26 -0400 The following dynamic module takes unbounded memory:/* gcc -I . -g -ggdb -fPIC foo.c -shared -o foo.so && echo running && emacs -Q -L . -batch -l foo */#include <emacs-module.h>int plugin_is_GPL_compatible;int emacs_module_init(struct emacs_runtime *ert) {emacs_env *env = ert->get_environment(ert);while (1) {int i;for (i = 0; i < 10000; i++) {emacs_value v = env->make_string(env, "asdads", 3);env->free_global_ref(env, env->make_global_ref(env, v));}env->funcall(env, env->intern(env, "garbage-collect"), 0, NULL);}}This is because env->make_global_ref/env->free_global_ref leak memory.env->free_global_ref fails to remove values from the hash table ofrefcounts. The following patch makes the program above run in constantspace.--- src/emacs-module.c 2017-06-30 16:00:36.776301646 -0400+++ src/emacs-module.c 2017-06-30 16:05:01.660120043 -0400@@ -308,7 +308,7 @@set_hash_value_slot (h, i, value);}else- hash_remove_from_table (h, value);+ hash_remove_from_table (h, obj);}}
--- End Message ---
--- Begin Message ---Subject: Re: bug#27587: 25.1; in the dynamic modules api, env->free_global_ref doesn't free anything Date: Sun, 09 Jul 2017 22:17:17 +0000 Valentin Gatien-Baron <address@hidden> schrieb am Mi., 5. Juli 2017 um 17:07 Uhr:The following dynamic module takes unbounded memory:/* gcc -I . -g -ggdb -fPIC foo.c -shared -o foo.so && echo running && emacs -Q -L . -batch -l foo */#include <emacs-module.h>int plugin_is_GPL_compatible;int emacs_module_init(struct emacs_runtime *ert) {emacs_env *env = ert->get_environment(ert);while (1) {int i;for (i = 0; i < 10000; i++) {emacs_value v = env->make_string(env, "asdads", 3);env->free_global_ref(env, env->make_global_ref(env, v));}env->funcall(env, env->intern(env, "garbage-collect"), 0, NULL);}}This is because env->make_global_ref/env->free_global_ref leak memory.env->free_global_ref fails to remove values from the hash table ofrefcounts. The following patch makes the program above run in constantspace.--- src/emacs-module.c 2017-06-30 16:00:36.776301646 -0400+++ src/emacs-module.c 2017-06-30 16:05:01.660120043 -0400@@ -308,7 +308,7 @@set_hash_value_slot (h, i, value);}else- hash_remove_from_table (h, value);+ hash_remove_from_table (h, obj);}}Good catch, installed as 22af69906cca871fdb893e06d6f10dbbab4518e6.
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |