--- Begin Message ---
|
Subject: |
[PATCH] gnu: Add heimdall. |
|
Date: |
Thu, 7 Sep 2017 00:36:53 +0200 |
* gnu/packages/android.scm (heimdall): New variable.
---
gnu/packages/android.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
index be3f50add..20bd21bdf 100644
--- a/gnu/packages/android.scm
+++ b/gnu/packages/android.scm
@@ -22,13 +22,18 @@
(define-module (gnu packages android)
#:use-module (guix packages)
+ #:use-module (guix download)
#:use-module (guix git-download)
+ #:use-module (guix build-system cmake)
#:use-module (guix build-system gnu)
#:use-module (guix build-system python)
#:use-module ((guix licenses) #:prefix license:)
#:use-module (gnu packages)
+ #:use-module (gnu packages compression)
#:use-module (gnu packages gnupg)
+ #:use-module (gnu packages libusb)
#:use-module (gnu packages python)
+ #:use-module (gnu packages qt)
#:use-module (gnu packages ssh)
#:use-module (gnu packages version-control)
#:use-module (gnu packages tls))
@@ -399,3 +404,51 @@ parts of the development workflow. Repo is not meant to
replace Git, only to
make it easier to work with Git. The repo command is an executable Python
script that you can put anywhere in your path.")
(license license:asl2.0)))
+
+(define-public heimdall
+ (package
+ (name "heimdall")
+ (version "1.4.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/Benjamin-Dobell/Heimdall/";
+ "archive/v" version ".tar.gz"))
+ (file-name (string-append "heimdall-" version ".tar.gz"))
+ (sha256
+ (base32 "1y7gwg3lipyp2zcysm2vid1qg5nwin9bxbvgzs28lz2rya4fz6sq"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release")
+ #:tests? #f ; No tests exist.
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'patch-invocations
+ (lambda* (#:key outputs #:allow-other-keys)
+ (substitute* '("heimdall-frontend/source/aboutform.cpp"
+ "heimdall-frontend/source/mainwindow.cpp")
+ (("start[(]\"heimdall\"")
+ (string-append "start(\"" (assoc-ref outputs "out")
+ "/bin/heimdall\"")))
+ #t))
+ (replace 'install
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (out-bin (string-append out "/bin"))
+ (out-lib (string-append out "/lib")))
+ (mkdir-p out-bin)
+ (mkdir-p out-lib)
+ (install-file "../build/bin/heimdall" out-bin)
+ (install-file "../build/bin/heimdall-frontend" out-bin)
+ (install-file "../build/libpit/libpit.a" out-lib)
+ #t))))))
+ (inputs
+ `(("libusb" ,libusb)
+ ("qtbase" ,qtbase)
+ ("zlib" ,zlib)))
+ (home-page "http://glassechidna.com.au/heimdall/";)
+ (synopsis "Samsung Flashing Tool")
+ (description
+ "@command{heimdall} can be used to flash firmware onto Samsung mobile
+devices.")
+ (license license:expat)))
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#28378] [PATCH] gnu: Add heimdall. |
|
Date: |
Tue, 3 Oct 2017 21:46:27 +0200 |
Le Wed, 20 Sep 2017 22:34:23 +0200,
address@hidden (Ludovic Courtès) a écrit :
> Hi Julien,
>
> Julien Lepiller <address@hidden> skribis:
>
> > From 0cd2378f5aa2626f8118d607a6b3558c212d80ec Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <address@hidden>
> > Date: Tue, 29 Aug 2017 23:54:16 +0200
> > Subject: [PATCH] gnu: Add heimdall.
> >
> > * gnu/packages/flashing-tools.scm (heimdall): New variable.
> >
> > Co-Authored-By: Danny Milosavljevic <address@hidden>
>
> It LGTM. I don’t see why libpit.a is needed, but I’ll let you
> decide. :-)
>
> > + (build-system cmake-build-system)
> > + (arguments
> > + `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release")
>
> Why not keep the default “RelWithDebInfo”?
That's what was documented in this package.
Pushed as f282aa530b91c8fecb910bc0a3323fcbd4d39ffb.
>
> Thanks!
>
> Ludo’.
--- End Message ---