[debbugs-tracker] bug#28635: closed ([PATCH] Allow configuring the disk image size of a virtual machine)

[GNU bug Tracking System]

Your message dated Wed, 4 Oct 2017 07:25:36 +0100
with message-id <address@hidden>
and subject line Re: [bug#28635] [PATCH 2/2] vm: Add disk-image-size to 
<virtual-machine>.
has caused the debbugs.gnu.org bug report #28635,
regarding [PATCH] Allow configuring the disk image size of a virtual machine
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28635: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28635
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Allow configuring the disk image size of a virtual machine Date: Thu, 28 Sep 2017 20:54:16 +0100

Allow configuring the size of the virtual machine disk when using the
virtual-matchine record type.

Christopher Baines (2):
  vm: Add a minimum root size.
  vm: Add disk-image-size to <virtual-machine>.

 gnu/system/vm.scm | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

pgpFFHrt2vuM3.pgp
Description: OpenPGP digital signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#28635] [PATCH 2/2] vm: Add disk-image-size to <virtual-machine>. Date: Wed, 4 Oct 2017 07:25:36 +0100

On Tue, 03 Oct 2017 15:12:04 +0200
address@hidden (Ludovic Courtès) wrote:

> Christopher Baines <address@hidden> skribis:
> 
> > * gnu/system/vm.scm (<virtual-machine>): Add disk-image-size.
> >   (port-forwardings->qemu-options): Use disk-image-size from
> >   <virtual-machine>.  
> 
> As long as “make check-system TESTS=basic” passes, fine with me!

It failed at first, as I had a the memory-size and disk-image-size
fields the wrong way around in a match statement, but after I fixed
that it worked fine.

I've now pushed these changes, thanks for your review :)

pgp2aPTTT39DE.pgp
Description: OpenPGP digital signature

--- End Message ---