[debbugs-tracker] bug#28198: closed ([PATCH] Add MongoDB package and service.)

[GNU bug Tracking System]

Your message dated Fri, 6 Oct 2017 21:29:52 +0100
with message-id <address@hidden>
and subject line Re: [bug#28198] [PATCH 3/3] services: Add MongoDB.
has caused the debbugs.gnu.org bug report #28198,
regarding [PATCH] Add MongoDB package and service.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28198: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28198
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Add MongoDB package and service. Date: Wed, 23 Aug 2017 10:18:31 +0100

This is a work in progress issue for supporting MongoDB in Guix.

Back in March 2016, Roel Janssen sent a working package patch to
guix-devel, but there was concern from those reviewing about the
security implications of the amount of third party code that is
included with the MongoDB source.

I've taken that original patch, and started to try and get MongoDB to
build using libraries and tools from Guix. In addition, I've added a
very basic service definition and system test.

This isn't ready to be merged yet, but I think it's good to work on in
public. Patches to follow...

pgpVqz8LU4wNS.pgp
Description: OpenPGP digital signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#28198] [PATCH 3/3] services: Add MongoDB. Date: Fri, 6 Oct 2017 21:29:52 +0100

On Wed, 04 Oct 2017 16:44:21 +0200
address@hidden (Ludovic Courtès) wrote:

> Christopher Baines <address@hidden> skribis:
> 
> > * gnu/services/databases.scm (%default-mongodb-configuration-file,
> >   %mongodb-accounts, mongodb-service-type): New variables.
> >   (<mongodb-configuration>): New record type.
> >   (mongodb-activation, mongodb-shepherd-service): New procedures.
> > * gnu/tests/databases.scm (%test-mongodb): New variable.
> > * doc/guix.text (Database Services): Add MongoDB documentation.  
>                 ^
> 
> texi :-)
> 
> [...]
> 
> > +(define mongodb-service-type
> > +  (service-type
> > +   (name 'mongodb)
> > +   (extensions
> > +    (list (service-extension shepherd-root-service-type
> > +                             (compose list
> > +                                      mongodb-shepherd-service))
> > +          (service-extension activation-service-type
> > +                             mongodb-activation)
> > +          (service-extension account-service-type
> > +                             (const %mongodb-accounts))))
> > +   (default-value
> > +     (mongodb-configuration))))  
> 
> Could you add a ‘description’ field?  :-)
> 
> Like “Run the MongoDB document database server.”
> 
> Apart from that it looks great.

I've added the explicit #t values to the two phases, fixed the texi
typo, and added the description, and now pushed.

Thanks again for reviewing Ludo :)

pgp2NBR0XP3k0.pgp
Description: OpenPGP digital signature

--- End Message ---