[debbugs-tracker] bug#28787: closed ([PATCH] emacs-build-system: Improve command patching.)

[GNU bug Tracking System]

Your message dated Sun, 15 Oct 2017 19:09:07 +0100
with message-id <address@hidden>
and subject line Re: [bug#28787] [PATCH 2/2] emacs-build-system: Change how 
patch-el-files substitutes commands.
has caused the debbugs.gnu.org bug report #28787,
regarding [PATCH] emacs-build-system: Improve command patching.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28787: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28787
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] emacs-build-system: Improve command patching. Date: Wed, 11 Oct 2017 15:40:29 +0100

I came across a couple of improvements when looking at packaging
emacs-org-plus-contrib.

Christopher Baines (2):
  emacs-build-system: Handle missing programs when patching.
  emacs-build-system: Change how patch-el-files substitutes commands.

 guix/build/emacs-build-system.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

pgp6UXR6gPwmn.pgp
Description: OpenPGP digital signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#28787] [PATCH 2/2] emacs-build-system: Change how patch-el-files substitutes commands. Date: Sun, 15 Oct 2017 19:09:07 +0100

On Fri, 13 Oct 2017 23:40:55 +0200
address@hidden (Ludovic Courtès) wrote:

> Christopher Baines <address@hidden> skribis:
> 
> > Previously the regex would match from /bin/ to a closing quote. However, 
> > this
> > is greedy, so will match up until the last ". This causes problems when 
> > there
> > are several quotes on the same line, for example:
> >
> > org-effectiveness.el:
> > 196:      (call-process "/bin/bash" nil t nil "-c" strplot)
> >
> > Therefore, change . to \S so that it doesn't include whitespace
> > characters. Changing to a lazy quantifier would be an option, if that were
> > supported.
> >
> > * guix/build/emacs-build-system.scm (patch-el-files): Change the regular
> >   expression used.  
> 
> Good catch, LGTM!

Great :) I've now pushed the updated version of these two patches.

pgpsHOdp1oyYF.pgp
Description: OpenPGP digital signature

--- End Message ---