[debbugs-tracker] bug#29099: closed ([PATCH] gnu: Add kodi-cli.)

[GNU bug Tracking System]

Your message dated Fri, 03 Nov 2017 06:57:05 +0300
with message-id <address@hidden>
and subject line Re: [bug#29099] [PATCH] gnu: Add kodi-cli.
has caused the debbugs.gnu.org bug report #29099,
regarding [PATCH] gnu: Add kodi-cli.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29099: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29099
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] gnu: Add kodi-cli. Date: Wed, 01 Nov 2017 09:48:31 +0300

From 741284b1619490859910fb402802ab10b31f0fd2 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <address@hidden>
Date: Wed, 1 Nov 2017 09:39:05 +0300
Subject: [PATCH] gnu: Add kodi-cli.

* gnu/packages/kodi.scm (kodi-cli): New variable.
---
 gnu/packages/kodi.scm | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gnu/packages/kodi.scm b/gnu/packages/kodi.scm
index c8a65af79..65621e152 100644
--- a/gnu/packages/kodi.scm
+++ b/gnu/packages/kodi.scm
@@ -25,11 +25,13 @@
   #:use-module (guix git-download)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system trivial)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages audio)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages avahi)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages cdrom)
   #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
@@ -426,3 +428,49 @@ plug-in system.")
                    license:public-domain          ;cpluff/examples
                    license:bsd-3                  ;misc, gtest
                    license:bsd-2)))))             ;xbmc/freebsd
+
+(define-public kodi-cli
+  (let ((commit "104dc23b2a993c8e6db8c46f4f8bec24b146549b") ; Add support for
+        (revision "1"))                                     ; `$HOME/.kodirc'.
+    (package
+      (name "kodi-cli")
+      (version (string-append "1.1-" revision "." (string-take commit 7)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference (url "https://github.com/nawar/kodi-cli";)
+                                    (commit commit)))
+                (sha256
+                 (base32
+                  "1xjhasc5gngfxpr1dlzy6q24w0wpdfjx12p43fanjppxw4i49n5p"))
+                (file-name (string-append name "-" version "-checkout"))))
+      (build-system trivial-build-system)
+      (inputs `(("bash" ,bash)))
+      (propagated-inputs `(("curl" ,curl)))
+      (arguments
+       `(#:modules ((guix build utils))
+         #:builder
+         (begin
+           (use-modules (guix build utils))
+           (copy-recursively (assoc-ref %build-inputs "source") ".")
+           (substitute* "kodi-cli"
+             (("/bin/bash") (string-append (assoc-ref %build-inputs "bash")
+                                           "/bin/bash")))
+           (install-file "kodi-cli" (string-append %output "/bin")))))
+      (home-page "https://github.com/nawar/kodi-cli";)
+      (synopsis "Bash script to send commands to Kodi using JSON RPC")
+      (description "@code{kodi-cli} provides the Bash script to send commands 
to
+Kodi using JSON RPC.
+
+Feautures:
+
address@hidden
address@hidden Play, pause, stop the current played video.
address@hidden Skip forward or backward in the current played video.
address@hidden Play or queue to the current list YouTube video.
address@hidden Interactive and noninteractive volume control.
address@hidden Interactive navigation.
address@hidden Send text.
address@hidden Toggle fullscreen.
address@hidden Update or clean Kodi libraries.
address@hidden itemize\n")
+      (license license:gpl2+))))
-- 
2.14.3

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#29099] [PATCH] gnu: Add kodi-cli. Date: Fri, 03 Nov 2017 06:57:05 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Marius Bakke <address@hidden> writes:

[...]

>> Maybe call this item of the feature list as
>> “Send text to the Kodi keyboard”?
>
> "Send text to the Kodi keyboard" is much better, thanks!
>
>> +      (arguments
>> +       `(#:modules ((guix build utils))
>> +         #:builder
>> +         (begin
>> +           (use-modules (guix build utils))
>> +           (copy-recursively (assoc-ref %build-inputs "source") ".")
>> +           (substitute* "kodi-cli"
>> +             (("/bin/bash") (string-append (assoc-ref %build-inputs "bash")
>> +                                           "/bin/bash"))
>> +             (("output=\\$\\((curl)" all curl)
>> +              (string-append "output=$("
>> +                             (assoc-ref %build-inputs "curl")
>> +                             "/bin/" curl))
>> +             (("play_youtube `(mpsyt)" all mpsyt)
>> +              (string-append "play_youtube `"
>> +                             (assoc-ref %build-inputs "mps-youtube")
>> +                             "/bin/" mpsyt)))
>
> FYI, you could also use (which "curl") etc from (guix build utils) here,
> but I usually prefer this form.

Thanks for notice.  I prefer a form used in attached patch, too.

>> address@hidden
>> address@hidden Play, pause, stop the current playing item.
>> address@hidden Skip forward or backward in the current playing item.
>
> These should be "currently playing".

Done.

>> address@hidden Play or queue to the current list YouTube videos.
>
> "... current list of YouTube videos."
>
> (note the "of")

Done.

> LGTM otherwise.  Don't forget to add a copyright line for yourself.

OK.  I think it's fine to merge it now.


Pushed as 72df48dbad95c3bc70a2962f496420ce3363d0de

Oleg,
Thanks.

signature.asc
Description: PGP signature

--- End Message ---