--- Begin Message ---
|
Subject: |
nsterm.m - unnecessary definition |
|
Date: |
Mon, 6 Nov 2017 16:13:32 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; NetBSD amd64; rv:51.0) Gecko/20100101 Firefox/51.0 SeaMonkey/2.48 |
Hi,
for GNUstep, the definition:
NSString *NSMenuDidBeginTrackingNotification;
at line 72 of nsterm.m is not needed, actually it results in:
nsterm.m:72:18: error: conflicting type qualifiers for
'NSMenuDidBeginTrackingNotification'
extern NSString *NSMenuDidBeginTrackingNotification;
^
In file included from /System/Library/Headers/AppKit/AppKit.h:90:0,
from nsgui.h:34,
from dispextern.h:76,
from nsterm.h:21,
from nsterm.m:48:
/System/Library/Headers/AppKit/NSMenu.h:823:31: note: previous
declaration of 'NSMenuDidBeginTrackingNotification' was here
APPKIT_EXPORT NSString* const NSMenuDidBeginTrackingNotification;
^
Makefile:381: recipe for target 'nsterm.o' failed
Thus either leave it only for MacOS (e.g. #ifndef GNUSTEP) or remove it
totally if it is not needed on mac.
Thanks - Riccardo
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#29171: nsterm.m - unnecessary definition |
|
Date: |
Mon, 6 Nov 2017 20:15:06 +0000 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, Nov 06, 2017 at 08:08:25PM +0000, Alan Third wrote:
> On Mon, Nov 06, 2017 at 04:13:32PM +0100, Riccardo Mottola wrote:
> > for GNUstep, the definition:
> >
> > NSString *NSMenuDidBeginTrackingNotification;
> >
> > at line 72 of nsterm.m is not needed, actually it results in:
>
> We’re not defining that anywhere in our code, and certainly not on
> line 72 of nsterm.m which looks like:
Sorry, spoke too soon. The definition is in Emacs 25, but it’s already
been removed in Emacs 26.
Please try the Emacs 26 pre‐release.
--
Alan Third
--- End Message ---