[debbugs-tracker] bug#29396: closed (Comm bug verified)

[GNU bug Tracking System]

Your message dated Thu, 23 Nov 2017 10:50:05 -0700
with message-id <address@hidden>
and subject line Re: bug#29396: Comm bug verified
has caused the debbugs.gnu.org bug report #29396,
regarding Comm bug verified
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29396: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29396
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Comm bug verified Date: Wed, 22 Nov 2017 09:15:56 -0500

Dear Maintainers

I guess the names are Richard M. Stallman and David MacKenzie.

I found a vierifiable bug in the utilitu comm. This is very important because hundreds maybe thousands of application rely on this app to make crucial decisions, in power plants, banks, etc. We nedd to trust it.

I have two files with phone numbers, one column, sorted (they pass the test sort -c). One is large and the other one is small. The  comm -12 --check-order file1.csv file2.csv falis to find matches, but another utility, join file1.csv file2.csv. does find a lot of matches.

The box is Centos 7 and 

comm --version
comm (GNU coreutils) 8.22

The only special think about my box is

export LC_ALL=C

please contact me to send you a zip file with the two files, or for security, plain ascii files, or maybe you can login to our lab box and execute the commands.

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#29396: Comm bug verified
>
>
>
>
> Date: 
>
> Thu, 23 Nov 2017 10:50:05 -0700
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
>
>
>
>
> (re-adding the mailing list)
>
> Hello,
>
> On 2017-11-22 12:39 PM, Saint Michael wrote:
> > Thanks for the explanation
> > Is there a place to download the source code?
> > I want to compile a version that ignore spaces on the right, since 99% 
> > of the time I forget to check the line endings.
> > or maybe you could consider a switch to the tool that would make it 
> > ignore traing spaces when comparing lines.
>
> The source code for GNU coreutils is available here:
>   https://git.savannah.gnu.org/cgit/coreutils.git
>
> However,
> I would recommend the 'sed' method below, as a much simpler
> way to remove trailing spaces (instead of maintaining a custom modified
> coreutils binaries).
>
>
> >     To remove the trailing spaces on the file, try:
> >
> >         $ sed 's/  *$//' file2.csv > file2-no-space.csv
> >
> >         $ comm -12 file1.csv file2-no-space.csv  | wc -l
> >         864
> >
> >         $ join file1.csv file2.csv | wc -l
> >         864
>
>
> regards,
>  - assaf
>
>
>
> --- End Message ---