emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#15587: closed ([PATCH] Edebug `destructuring-bind'


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#15587: closed ([PATCH] Edebug `destructuring-bind' dotted spec)
Date: Sun, 26 Nov 2017 23:03:02 +0000

Your message dated Sun, 26 Nov 2017 15:02:27 -0800
with message-id <address@hidden>
and subject line Re: bug#6415: [PATCH] fix edebug instrumentation of dotted 
pairs in macros
has caused the debbugs.gnu.org bug report #6415,
regarding [PATCH] Edebug `destructuring-bind' dotted spec
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
6415: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6415
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] Edebug `destructuring-bind' dotted spec Date: Fri, 11 Oct 2013 12:39:37 +0200 User-agent: mu4e 0.9.9.5; emacs 24.3.4
Hi,

Currently it's not possible to edebug

(defun foo (z)
  (destructuring-bind (x . y) z (+ x y)))

I attach a small patch to fix this.

>From 51a191c06f210eecf594be384e9b835afb9a818f Mon Sep 17 00:00:00 2001
From: Oleh Krehel <address@hidden>
Date: Fri, 11 Oct 2013 12:34:03 +0200
Subject: [PATCH] * emacs-lisp/cl-macs.el: (cl-destructuring-bind): added
 dotted form as an option for edebug.

Edebug will now work for:

(defun foo (z)
  (destructuring-bind (x . y) z (+ x y)))
---
 emacs-lisp/cl-macs.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs-lisp/cl-macs.el b/emacs-lisp/cl-macs.el
index 60fdc09..a84e677 100644
--- a/emacs-lisp/cl-macs.el
+++ b/emacs-lisp/cl-macs.el
@@ -565,7 +565,7 @@ its argument list allows full Common Lisp conventions."
 (defmacro cl-destructuring-bind (args expr &rest body)
   "Bind the variables in ARGS to the result of EXPR and execute BODY."
   (declare (indent 2)
-           (debug (&define cl-macro-list def-form cl-declarations def-body)))
+           (debug (&define [&or cl-macro-list (sexp . sexp)] def-form 
cl-declarations def-body)))
   (let* ((cl--bind-lets nil) (cl--bind-forms nil) (cl--bind-inits nil)
         (cl--bind-defs nil) (cl--bind-block 'cl-none) (cl--bind-enquote nil))
     (cl--do-arglist (or args '(&aux)) expr)
-- 
1.8.4

regards,
Oleh

--- End Message ---
--- Begin Message --- Subject: Re: bug#6415: [PATCH] fix edebug instrumentation of dotted pairs in macros Date: Sun, 26 Nov 2017 15:02:27 -0800 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)
Gemini Lasswell <address@hidden> writes:

> Here's a new patch for this bug, based on the ideas in Steve's patch.

I've pushed this patch to emacs-26.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]