[debbugs-tracker] bug#29628: closed (services: nginx: Replace 'http-port' and 'https-port' with 'listen'.)

[GNU bug Tracking System]

Your message dated Mon, 18 Dec 2017 12:06:43 +0100
with message-id <address@hidden>
and subject line Re: [bug#29628] [PATCH] services: nginx: Replace 'http-port' 
and 'https-port' with 'listen'.
has caused the debbugs.gnu.org bug report #29628,
regarding services: nginx: Replace 'http-port' and 'https-port' with 'listen'.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29628: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29628
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> services: nginx: Replace 'http-port' and 'https-port' with 'listen'.
>
>
>
>
> Date: 
>
> Sat, 09 Dec 2017 19:41:19 +0100
>
>
>
>
> User-agent: 
>
> mu4e 0.9.18; emacs 25.3.1
>
>
>
>
> This patch allows to set several 'listen' directives, each of them being
> a string.
>
> See http://nginx.org/en/docs/http/ngx_http_core_module.html#listen.
>
> It may break user configurations.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#29628] [PATCH] services: nginx: Replace 'http-port' and 'https-port' with 'listen'.
>
>
>
>
> Date: 
>
> Mon, 18 Dec 2017 12:06:43 +0100
>
>
>
>
> User-agent: 
>
> mu4e 0.9.18; emacs 25.3.1
>
>
>
>
> Christopher Baines <address@hidden> writes:
>
> > Clément Lassieur <address@hidden> writes:
> >
> >> * doc/guix.texi (Web Services, Version Control Services): Update accordingly.
> >> * gnu/services/certbot.scm (certbot-nginx-server-configurations): Likewise.
> >> * gnu/services/version-control.scm (%cgit-configuration-nginx): Likewise.
> >> * gnu/services/web.scm (<nginx-server-configuration>,
> >> emit-nginx-server-config): Likewise.
> >> * gnu/tests/version-control.scm (%cgit-configuration-nginx,
> >> %git-nginx-configuration): Likewise.
> >> * gnu/tests/web.scm (%nginx-servers): Likewise.
> >
> > This looks good to me. Unfortunately this conflicts with some changes I
> > made to the nginx service, so it would be good if you could send an
> > updated patch.
> >
> > I think an extra use of the old configuration might have also appeared
> > in the docs/services as well.
>
> I updated it and pushed it.  Thank you for reviewing!
>
> Clément
>
>
> --- End Message ---