[debbugs-tracker] bug#29956: closed (26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47)

[GNU bug Tracking System]

Your message dated Wed, 03 Jan 2018 15:35:38 -0500
with message-id <address@hidden>
and subject line Re: bug#29956: 26.0.90; `d' in *VC-history*: Wrong type 
argument: sequencep, 47
has caused the debbugs.gnu.org bug report #29956,
regarding 26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29956: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29956
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47
>
>
>
>
> Date: 
>
> Tue, 02 Jan 2018 22:50:52 -0500
>
>
>
>
> Package: Emacs
> Version: 26.0.90
>
>
>     % src/emacs -Q lisp/emacs-lisp/pcase.el
>     ...Select the first (def-edebug-spec ...)
>     C-x v h
>     In the *VC-history* buffer, hit `d'
>
> This gives me `Wrong type argument: sequencep, 47'
> [ Which file you use, and which region of the file you select doesn't
>   really matter.  ]
>
> The patch below fixes it for me.
>
> Is it OK to install it into emacs-26, or should I keep it on `master`?
>
> FWIW, it's not a new bug in Emacs-26 and it's not terribly urgent to fix
> it, e.g. because you can use `D' which does work (tho it doesn't do
> quite the same), so I'm fine with either choice.
>
>
>         Stefan
>
>
> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
> index 7c502f88df..0a87e70017 100644
> --- a/lisp/vc/vc.el
> +++ b/lisp/vc/vc.el
> @@ -2426,9 +2426,11 @@ vc-region-history
>        (setq-local vc-log-view-type 'long))
>      (vc-call region-history file buf lfrom lto)
>      (with-current-buffer buf
> +      (setq default-directory (file-name-directory file))
>        (vc-call-backend backend 'region-history-mode)
>        (set (make-local-variable 'log-view-vc-backend) backend)
> -      (set (make-local-variable 'log-view-vc-fileset) file)
> +      (set (make-local-variable 'log-view-vc-fileset)
> +           (list (file-relative-name file)))
>        (set (make-local-variable 'revert-buffer-function)
>            (lambda (_ignore-auto _noconfirm)
>               (with-current-buffer buf
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#29956: 26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47
>
>
>
>
> Date: 
>
> Wed, 03 Jan 2018 15:35:38 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
>
>
>
>
> > It's okay for emacs-26, but I'm curious why did you need the
> > default-directory part.  Is that related to the problem?
>
> I checked the value of log-view-vc-fileset elsewhere and they seem to
> use absolute file names.  So I tried again with (list file) and it
> worked fine, not sure why I got an error when I checked last time.
> So I installed the patch below instead,
>
>
>         Stefan
>
>
> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
> index 7c502f88df..f8d63d1498 100644
> --- a/lisp/vc/vc.el
> +++ b/lisp/vc/vc.el
> @@ -2428,7 +2428,7 @@ vc-region-history
>      (with-current-buffer buf
>        (vc-call-backend backend 'region-history-mode)
>        (set (make-local-variable 'log-view-vc-backend) backend)
> -      (set (make-local-variable 'log-view-vc-fileset) file)
> +      (set (make-local-variable 'log-view-vc-fileset) (list file))
>        (set (make-local-variable 'revert-buffer-function)
>            (lambda (_ignore-auto _noconfirm)
>               (with-current-buffer buf
>
>
> --- End Message ---