[debbugs-tracker] bug#28832: closed ([PATCH 0/3] gnu: Add emacs-json-mode.)

[GNU bug Tracking System]

Your message dated Mon, 15 Jan 2018 15:01:01 +0300
with message-id <address@hidden>
and subject line Re: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat.
has caused the debbugs.gnu.org bug report #28832,
regarding [PATCH 0/3] gnu: Add emacs-json-mode.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28832: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28832
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/3] gnu: Add emacs-json-mode.
>
>
>
>
> Date: 
>
> Sat, 14 Oct 2017 12:51:52 +0300
>
>
>
>
> >From b3b7b79f85e3b2aca6322e9c994b0fe0a666825d Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <address@hidden>
> Date: Sat, 14 Oct 2017 12:50:21 +0300
> Subject: [PATCH 0/3] gnu: Add emacs-json-mode.
>
> 2 tests fails in emacs-json-reformat.
>
> Oleg Pykhalov (3):
>   gnu: Add emacs-json-reformat.
>   gnu: Add emacs-json-snatcher.
>   gnu: Add emacs-json-mode.
>
>  gnu/packages/emacs.scm | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 92 insertions(+)
>
> -- 
> 2.14.2
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Date: Mon, 15 Jan 2018 15:01:01 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Hello Ludovic,

address@hidden (Ludovic Courtès) writes:

[...]

>>> From d589de21acb02d0fba7aee3b48e5f42d7bd8957e Mon Sep 17 00:00:00 2001
>>> From: Oleg Pykhalov <address@hidden>
>>> Date: Tue, 12 Dec 2017 01:41:08 +0300
>>> Subject: [PATCH] gnu: Add emacs-json-reformat.
>>>
>>> * gnu/packages/patches/emacs-json-reformat-fix-tests.patch: New file.
>>> * gnu/local.mk (dist_patch_DATA): Add this.
>>> * gnu/packages/emacs.scm (emacs-json-reformat): New variable.
>>
>> [...]
>>
>>> diff --git a/gnu/packages/patches/emacs-json-reformat-fix-tests.patch 
>>> b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch
>>> new file mode 100644
>>> index 000000000..23a239582
>>> --- /dev/null
>>> +++ b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch
>>> @@ -0,0 +1,28 @@
>>> +Copyright © 2017 Oleg Pykhalov <address@hidden>
>>> +
>>> +This patch fixes tests for Emacs 25.
>>
>> Please mention <https://github.com/gongo/json-reformat/issues/33> here.
>>
>> OK with these changes!
>
> We went on discussing other things and forgot about the patch.  :-)
> Could you commit it with these changes, Oleg?

I thought we suspend this until automation of "-L" flags.
Seems like a similar discussion[1] gets stuck too.
Pushed as b0912e9fdbffab15d9a754b2922778cfbd1fac2a

Also pushed emacs-json-mode as dd72837dff128dbb1258826fe39467d1ef000ac1

I'll close current bug report.

Footnotes: 
[1]  https://lists.nongnu.org/archive/html/guix-patches/2017-12/msg00640.html

Thanks,
Oleg.

signature.asc
Description: PGP signature

--- End Message ---