[debbugs-tracker] bug#29896: closed ([PATCH core-updates] gnu: java-asm: Update to 6.0.)

[GNU bug Tracking System]

Your message dated Sat, 20 Jan 2018 13:43:06 -0800
with message-id <address@hidden>
and subject line Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
has caused the debbugs.gnu.org bug report #29896,
regarding [PATCH core-updates] gnu: java-asm: Update to 6.0.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29896: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29896
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH core-updates] gnu: java-asm: Update to 6.0.
>
>
>
>
> Date: 
>
> Fri, 29 Dec 2017 20:00:22 +0100
>
>
>
>
> * gnu/packages/java.scm (java-asm): Update to 6.0.
> [inputs]: Add java-aqute-bndlib, java-aqute-libg. (New dependencies)
> [arguments]: Adjust make-flags, so that the build does not complain about unset 
> properties.
> ---
>  gnu/packages/java.scm | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 41f9af87e..8a244328f 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -2663,15 +2663,18 @@ archives (jar).")
>  (define-public java-asm
>    (package
>      (name "java-asm")
> -    (version "5.2")
> +    (version "6.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://download.forge.ow2.org/asm/";
>                                    "asm-" version ".tar.gz"))
>                (sha256
>                 (base32
> -                "0kxvmv5275rnjl7jv0442k3wjnq03ngkb7sghs78avf45pzm4qgr"))))
> +                "115l5pqblirdkmzi32dxx7gbcm4jy0s14y5wircr6h8jdr9aix00"))))
>      (build-system ant-build-system)
> +    (inputs
> +     `(("java-aqute-bndlib" ,java-aqute-bndlib)
> +       ("java-aqute-libg" ,java-aqute-libg)))
>      (arguments
>       `(#:build-target "compile"
>         ;; The tests require an old version of Janino, which no longer compiles
> @@ -2679,7 +2682,8 @@ archives (jar).")
>         #:tests? #f
>         ;; We don't need these extra ant tasks, but the build system asks us to
>         ;; provide a path anyway.
> -       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo"))
> +       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo")
> +                          (string-append "-Dbiz.aQute.bnd.path=" (assoc-ref 
> %build-inputs "java-aqute-bndlib")))
>         #:phases
>         (modify-phases %standard-phases
>           (add-before 'install 'build-jars
> -- 
> 2.15.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. Date: Sat, 20 Jan 2018 13:43:06 -0800 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Gábor Boskovits <address@hidden> writes:

> Actually I am not sure, that bnd is used runtime. How could we check that?

The only class in the java-asm source code that uses bnd seems to be
ModuleInfoBndPlugin.java.  I checked by grepping for imports that
mentioned the string "bnd".  This class is declared public, and it is
included in the output JAR, so it is technically possible for code that
depends on java-asm to use this class (and therefore java-aqute-bndlib)
at runtime, even though there might also be code that depends on
java-asm that does not use this class at runtime.  So it seems
reasonable to make it a propagated-input.  The only downside is that
java-aqute-bndlib is 125% larger than java-asm (1.8 MiB compared to 0.8
MiB).

I've committed this patch as d0e9ded713e06790aad4992de7c26d075d18b86d,
with the changes we agreed upon.  I've also added a copyright line for
both you and me gnu/packages/java.scm.

Julien Lepiller <address@hidden> writes:

> There's a method to get references to a dependency in java: you can put
> it in the MANIFEST.MF file as:
>
> Class-Path: /gnu/store/...
>
> It's a space-separated list of jar files that have to be added to the
> classpath. This could be done in a phase that runs just before the
> build phase, like the phase that adds a Main-Class.

We've considered using this feature, but I don't know if anybody
followed through and tried it out.  Your help would be welcome!  Prior
discussions can be found here:

https://lists.gnu.org/archive/html/guix-devel/2017-04/msg00249.html
https://lists.gnu.org/archive/html/guix-devel/2017-05/msg00019.html

If you want to discuss this further, please start a new thread on
address@hidden

Ricardo Wurmus <address@hidden> writes:

> Chris Marusich <address@hidden> writes:
>
>> The installed software still won't
>> work without additional work on the part of the user (e.g., the user
>> needs to set the CLASSPATH when invoking java, or use java's -cp
>> option), but for now at least making the input a propagated input will
>> ensure that it gets installed alongside the package which at runtime
>> requires it, which is better than nothing.
>
> This can be fixed by adding a search path specification for CLASSPATH to
> the icedtea packages.

I think that's a good idea!  I'll follow up with a separate patch later,
unless you beat me to it.

-- 
Chris

signature.asc
Description: PGP signature

--- End Message ---