[debbugs-tracker] bug#30400: closed ([PATCH] gnu: clementine: Remove Spotify downloader.)

[GNU bug Tracking System]

Your message dated Thu, 15 Feb 2018 10:33:24 +0100
with message-id <address@hidden>
and subject line Re: [bug#30400] [PATCH] gnu: clementine: Remove Spotify 
downloader.
has caused the debbugs.gnu.org bug report #30400,
regarding [PATCH] gnu: clementine: Remove Spotify downloader.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
30400: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30400
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] gnu: clementine: Remove Spotify downloader. Date: Thu, 08 Feb 2018 23:09:19 +0000

Hi Guix!

I realized today that a new version of crypto++ was out so I set out to
update it but Clementine failed to compile. There's a patch on master [0]
that fixes the issue so I was going to apply it when I realized the bit
of code in question downloads a binary blob to support Spotify.  It
turns out there's a button in the preference menu that allows users to
download this proprietary blob, and crypto++ appears to be used to check
it.

So I thought that rather than apply the patch, we should probably remove
support for this download button all together. There is a flag that
allows not compiling "spotifyblobdownloader.cpp".

Also, this was also the only place in the codebase that used crypto++ so
we can drop this input.

What do you think?

[0]: 
https://github.com/clementine-player/Clementine/commit/38c1f8777cecc7b2f91fecbcc48c41479839304b.patch

0001-gnu-clementine-Remove-Spotify-downloader.patch
Description: Text Data

0002-gnu-crypto-Update-to-6.0.0.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader.
>
>
>
>
> Date: 
>
> Thu, 15 Feb 2018 10:33:24 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
>
>
>
>
> Leo Famulari <address@hidden> skribis:
>
> > On Thu, Feb 08, 2018 at 11:09:19PM +0000, Pierre Langlois wrote:
> >> From 9d9b90882491ff2ebf6f3a3580d4d7dbcdf57c72 Mon Sep 17 00:00:00 2001
> >> From: Pierre Langlois <address@hidden>
> >> Date: Thu, 8 Feb 2018 09:57:41 +0000
> >> Subject: [PATCH 2/2] gnu: crypto++: Update to 6.0.0.
> >> 
> >> * gnu/packages/crypto.scm (crypto++): Update to 6.0.0.
> >> * gnu/packages/patches/crypto++-fix-dos-in-asn.1-decoders.patch: Delete
> >> file.
> >> * gnu/local.mk (dist_patch_DATA): Remove it.
> >
> > I didn't push this patch yet because 1) it doesn't apply and 2) I have
> > to go AFK now and don't have time to make it apply. I'll do it later
> > today unless somebody does it first.
>
> Pushed as 6ca15c9ef615979862a07c02bd316e7f12a0c7ca.
>
> Thanks!
>
> Ludo'.
>
>
> --- End Message ---