emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#30640: closed ([patch] replace last cl)


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#30640: closed ([patch] replace last cl)
Date: Thu, 01 Mar 2018 15:50:01 +0000

Your message dated Thu, 1 Mar 2018 16:48:12 +0100
with message-id <address@hidden>
and subject line Re: bug#30640: [patch] replace last cl
has caused the debbugs.gnu.org bug report #30640,
regarding [patch] replace last cl
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
30640: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30640
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [patch] replace last cl Date: Tue, 27 Feb 2018 18:47:33 -0600 User-agent: mu4e 1.0; emacs 26.0.91
I think this takes case of the last (require 'cl) statement.

Thanks,
Alex

------------------------------------------------------------

>From 0befaa759ff22e9a8518c17095439fe11952e60b Mon Sep 17 00:00:00 2001
From: Alex Branham <address@hidden>
Date: Tue, 27 Feb 2018 18:45:03 -0600
Subject: [PATCH] * tex.el: replace (last?) 'cl with 'cl-lib

---
 tex.el | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/tex.el b/tex.el
index 8863a886..b7891a14 100644
--- a/tex.el
+++ b/tex.el
@@ -1,6 +1,6 @@
 ;;; tex.el --- Support for TeX documents.
 
-;; Copyright (C) 1985-1987, 1991, 1993-2017 Free Software Foundation, Inc.
+;; Copyright (C) 1985-1987, 1991, 1993-2018 Free Software Foundation, Inc.
 
 ;; Maintainer: address@hidden
 ;; Keywords: tex
@@ -34,7 +34,7 @@
 (require 'custom)
 (require 'tex-site)
 (eval-when-compile
-  (require 'cl))
+  (require 'cl-lib))
 
 (defgroup TeX-file nil
   "Files used by AUCTeX."
@@ -2710,11 +2710,11 @@ are returned."
                (dolist (subdir subdirs)
                  (setq path (file-name-as-directory (concat item subdir)))
                  (when (file-exists-p path)
-                   (pushnew path input-dir-list :test #'equal)))
+                   (cl-pushnew path input-dir-list :test #'equal)))
              (setq path (file-name-as-directory item))
              (when (file-exists-p path)
-               (pushnew path input-dir-list :test #'equal))))
-         ;; No duplication in result is assured since `pushnew' is
+               (cl-pushnew path input-dir-list :test #'equal))))
+         ;; No duplication in result is assured since `cl-pushnew' is
          ;; used above.  Should we introduce an option for speed just
          ;; to accumulate all the results without care for
          ;; duplicates?
@@ -3131,6 +3131,7 @@ FORCE is not nil."
 
 (defcustom TeX-complete-word 'ispell-complete-word
   "*Function to call for completing non-macros in `tex-mode'."
+  :type 'function
   :group 'TeX-macro)
 
 (defcustom TeX-complete-expert-commands nil
@@ -4521,7 +4522,7 @@ EXTENSIONS defaults to `TeX-file-extensions'."
                                    "$TEXMFDIST")
                                   "latex"))
       (when (file-readable-p dir)
-        (pushnew dir list :test #'equal)))
+        (cl-pushnew dir list :test #'equal)))
     (nreverse list)))
 
 (defcustom TeX-tree-roots (TeX-tree-roots)
@@ -6404,7 +6405,7 @@ NAME may be a package, a command, or a document."
       (when (memq major-mode (nth 1 elt))
        (let ((completions (funcall (nth 2 elt))))
          (unless (null completions)
-            (pushnew (cons completions (nth 0 elt)) docs :test #'equal)))))
+            (cl-pushnew (cons completions (nth 0 elt)) docs :test #'equal)))))
     (if (null docs)
        (progn
          (if (executable-find "texdoc")
@@ -6528,7 +6529,7 @@ of the car of `ispell-tex-skip-alists'.  This only 
happens if
     (let ((raws (car ispell-tex-skip-alists))
          (envs (cadr ispell-tex-skip-alists)))
       (dolist (x skip)
-       (pushnew x raws :test #'equal))
+       (cl-pushnew x raws :test #'equal))
       (setq ispell-tex-skip-alists (list raws envs)))))
 
 (defun TeX-ispell-skip-setcdr (skip)
@@ -6541,7 +6542,7 @@ of the cdr of `ispell-tex-skip-alists'.  This only 
happens if
     (let ((raws (car ispell-tex-skip-alists))
          (envs (cadr ispell-tex-skip-alists)))
       (dolist (x skip)
-       (pushnew x envs :test #'equal))
+       (cl-pushnew x envs :test #'equal))
       (setq ispell-tex-skip-alists (list raws envs)))))
 
 (defun TeX-ispell-tex-arg-end (&optional arg1 arg2 arg3)
-- 
2.16.2


Attachment: 0001-tex.el-replace-last-cl-with-cl-lib.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#30640: [patch] replace last cl Date: Thu, 1 Mar 2018 16:48:12 +0100
2018-03-01 16:43 GMT+01:00 Alex Branham <address@hidden>:
> Whoops! I didn't think about checking the other files for cl functions.
> Since this removes the last cl function, the byte-compiler didn't know
> about the cl functions anymore. There was one lurking in latex.el that
> we must've missed before.

Now

    make && make check

is successful!  Patch applied, thanks.

Bye,
Mosè


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]