[debbugs-tracker] bug#30701: closed ([PATCH 0/4] PostgreSQL service changes (add record type, and system test))

[GNU bug Tracking System]

Your message dated Tue, 13 Mar 2018 17:37:30 +0000
with message-id <address@hidden>
and subject line Re: [bug#30701] [PATCH 1/3] services: Rework the PostgreSQL 
config file to use a record type.
has caused the debbugs.gnu.org bug report #30701,
regarding [PATCH 0/4] PostgreSQL service changes (add record type, and system 
test)
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
30701: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30701
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH 0/4] PostgreSQL service changes (add record type, and system test) Date: Sun, 04 Mar 2018 19:10:43 +0000 User-agent: mu4e 0.9.18; emacs 25.3.1

I was mostly adding the system test, but also ended up reworking the
service so that Shepherd knows about the PID file.


Christopher Baines (4):
  services: Rework the PostgreSQL config file to use a record type.
  services: Use a external pid file for PostgreSQL.
  tests: databases: Add a system test for PostgreSQL.
  services: databases: Add postgresql-configuration record exports.

 gnu/services/databases.scm | 125 ++++++++++++++++++++++++++++++++++++---------
 gnu/tests/databases.scm    |  59 +++++++++++++++++++++
 2 files changed, 161 insertions(+), 23 deletions(-)

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#30701] [PATCH 1/3] services: Rework the PostgreSQL config file to use a record type. Date: Tue, 13 Mar 2018 17:37:30 +0000 User-agent: mu4e 1.0; emacs 25.3.1

Sorry, I made some changes, and merged these patches on the weekend, but
I forgot to reply.

Clément Lassieur <address@hidden> writes:

> Christopher Baines <address@hidden> writes:
>
>> For the default config file representation. This makes it possible to more
>> easily change the configuration file, and have dynamic content. In 
>> particular,
>> I'm looking at adding a pid file location to the config file.
>
>                              ^
> Could you please remove this last sentence (with the pid file)?

Done.

>> * gnu/services/databases.scm (<postgresql-config-file>): New record type.
>> (%default-postgres-config): Remove this, it's been replaced by the
>> configuration file.
>> (<postgresql-configuration>): Alter the default for the config file field.
>> (postgresql-service): Alter the default value for the config-file parameter.
>> ---
>>  gnu/services/databases.scm | 86 
>> +++++++++++++++++++++++++++++++++++-----------
>>  1 file changed, 66 insertions(+), 20 deletions(-)
>>
>> diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm
>> index 3ca8f471f..f7d5fffd0 100644
>> --- a/gnu/services/databases.scm
>> +++ b/gnu/services/databases.scm
>> @@ -26,11 +26,20 @@
>>    #:use-module (gnu system shadow)
>>    #:use-module (gnu packages admin)
>>    #:use-module (gnu packages databases)
>> +  #:use-module (guix store)
>
> I don't think (guix store) is used.  Is it?

It wasn't, I've removed it.

>>    #:use-module (guix modules)
>>    #:use-module (guix records)
>>    #:use-module (guix gexp)
>
> ...
>
>> +        `(("log_destination" ,@(with-single-quotes log-destination))
>> +          ("hba_file" ,@(with-single-quotes hba-file))
>> +          ("ident_file" ,@(with-single-quotes ident-file))
>                                     ^
> Could you please use a shorter name?  Like "enclose", so that we won't
> go over 80 columns too easily :-).

I went with quote' as I think that works well.

> Apart from those small things, the three patches LGTM.  Thank you
> again!

Thanks for taking a look and for your comments :)

Chris

signature.asc
Description: PGP signature

--- End Message ---