[debbugs-tracker] bug#30716: closed (guix pull: error: Git error: unable to parse OID - contains invalid characters when COMMIT-ID is shortened)

[GNU bug Tracking System]

Your message dated Sun, 18 Mar 2018 00:04:58 +0100
with message-id <address@hidden>
and subject line Re: bug#30716: guix pull: error: Git error: unable to parse 
OID - contains invalid characters when COMMIT-ID is shortened
has caused the debbugs.gnu.org bug report #30716,
regarding guix pull: error: Git error: unable to parse OID - contains invalid 
characters when COMMIT-ID is shortened
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
30716: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30716
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: guix pull: error: Git error: unable to parse OID - contains invalid characters when COMMIT-ID is shortened Date: Mon, 5 Mar 2018 21:29:12 +0100

Guix pull has the wrong error message when the commit-id for the
"--commit" parameter is too short:

$>guix pull --commit=d20647722ad36024a3a0b6e1e75c1ba49b9f61d
Updating from Git repository at
'https://git.savannah.gnu.org/git/guix.git'... guix pull: error: Git
error: unable to parse OID - contains invalid characters

Instead of that error-message it should complain that the OID is too
short.

Even better, it should just accept a shortened OID and use it, as long
as it is unique.

Note: When there really is a wrong character used, this error message
is also correctly shown:

$>guix pull --commit=d20647722ad36024a3a0b6e1e75c1ba49b9f61dz
Updating from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
guix pull: error: Git error: unable to parse OID - contains invalid characters


Note: If the OID is long enough and well-formed, but just non-existent,
the error message is adequately correct:

$> guix pull --commit=d20647722ad36024a3a0b6e1e75c1ba49b9f61dd 
Updating from Git repository at 
'https://git.savannah.gnu.org/git/guix.git'... guix pull: error: Git
error: object not found - no match for id
(d20647722ad36024a3a0b6e1e75c1ba49b9f61dd)


Björn

pgpKfOx0CyWdy.pgp
Description: OpenPGP digital signature

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#30716: guix pull: error: Git error: unable to parse OID - contains invalid characters when COMMIT-ID is shortened
>
>
>
>
> Date: 
>
> Sun, 18 Mar 2018 00:04:58 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
>
>
>
>
> Hi Björn,
>
> Björn Höfling <address@hidden> skribis:
>
> > $>guix pull --commit=d20647722ad36024a3a0b6e1e75c1ba49b9f61dz
> > Updating from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
> > guix pull: error: Git error: unable to parse OID - contains invalid characters
>
> This was actually and out-of-bounds read in Guile-Git (!), now fixed:
>
>   
> https://gitlab.com/guile-git/guile-git/commit/d37a40de69d727529fe2aebb6afcf362bf8e9ba7
>
> Furthermore, ‘guix pull’ now supports short IDs provided a recent-enough
> Guile-Git is available:
>
>   
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=95bd9f65a8ee64d17707a76aebc8720bbd961b68
>
> Thanks,
> Ludo’.
>
>
> --- End Message ---