[debbugs-tracker] bug#31265: closed ([PATCH 0/6] Add Android NDK build system.)

[GNU bug Tracking System]

Your message dated Wed, 9 May 2018 19:34:08 +0200
with message-id <address@hidden>
and subject line Re: [bug#31265] Add Android NDK build system.
has caused the debbugs.gnu.org bug report #31265,
regarding [PATCH 0/6] Add Android NDK build system.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
31265: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31265
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/6] Add Android NDK build system.
>
>
>
>
> Date: 
>
> Thu, 26 Apr 2018 02:13:19 +0200
>
>
>
>
> Danny Milosavljevic (6):
>   gnu: Add address@hidden
>   build: Add the Android NDK build-system.
>   gnu: liblog: Use android-ndk-build-system.
>   gnu: libbase: Use android-ndk-build-system.
>   gnu: adb: Use android-ndk-build-system.
>   gnu: mkbootimg: Install "bootimg.h".
>
>  Makefile.am                                  |   2 +
>  gnu/local.mk                                 |   1 +
>  gnu/packages/android.scm                     | 199 +++++++++------------------
>  gnu/packages/linux.scm                       |  35 ++++-
>  gnu/packages/patches/adb-add-libraries.patch |  19 +++
>  guix/build-system/android-ndk.scm            | 126 +++++++++++++++++
>  guix/build/android-ndk-build-system.scm      |  86 ++++++++++++
>  7 files changed, 328 insertions(+), 140 deletions(-)
>  create mode 100644 gnu/packages/patches/adb-add-libraries.patch
>  create mode 100644 guix/build-system/android-ndk.scm
>  create mode 100644 guix/build/android-ndk-build-system.scm
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#31265] Add Android NDK build system. Date: Wed, 9 May 2018 19:34:08 +0200

Hi Julien,

thanks for the review!

On Tue, 1 May 2018 12:27:14 +0200
Julien Lepiller <address@hidden> wrote:

> this LGTM, but could you add android-make-stub in a separate patch?

Sure, done.

> Also, could you add a description of the new build system to the manual?

Yeah, did that now.

I pushed to master as commits 72aa295e44d46f80a037bfdc68f831bee56efbab to
ad23a3fbabb3cdc4ad19b524f517ad312768b92c (inclusive).

pgpBYfVSvnnUP.pgp
Description: OpenPGP digital signature

--- End Message ---