emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#31490: closed ([PATCH] gnu: Add emacs-cmake-mode.)


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#31490: closed ([PATCH] gnu: Add emacs-cmake-mode.)
Date: Tue, 22 May 2018 14:26:02 +0000

Your message dated Tue, 22 May 2018 17:25:43 +0300
with message-id <address@hidden>
and subject line Re: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode.
has caused the debbugs.gnu.org bug report #31490,
regarding [PATCH] gnu: Add emacs-cmake-mode.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
31490: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31490
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] gnu: Add emacs-cmake-mode. Date: Fri, 18 May 2018 15:27:16 +0300
* gnu/packages/cmake.scm (emacs-cmake-mode): New public variable.
---
 gnu/packages/cmake.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/cmake.scm b/gnu/packages/cmake.scm
index e6c5c4e79..eba7a92c0 100644
--- a/gnu/packages/cmake.scm
+++ b/gnu/packages/cmake.scm
@@ -206,3 +206,20 @@ and workspaces that can be used in the compiler 
environment of your choice.")
     (inputs
      `(("rhash" ,rhash)
        ,@(package-inputs cmake)))))
+
+(define-public emacs-cmake-mode
+  (package
+    (inherit cmake)
+    (name "emacs-cmake-mode")
+    (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'chdir-elisp
+           ;; Elisp directory is not in root of the source.
+           (lambda _
+             (chdir "Auxiliary"))))))
+    (synopsis "Emacs major mode for editing Cmake expressions")
+    (description "@code{cmakeos-mode} provides an Emacs major mode for editing
+Cmake files.  It supports syntax highlighting, indenting and refilling of
+comments.")))
-- 
2.17.0




--- End Message ---
--- Begin Message --- Subject: Re: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode. Date: Tue, 22 May 2018 17:25:43 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
Maxim Cournoyer <address@hidden> writes:

[…]

>> +             (substitute* "Auxiliary/CMakeLists.txt"
>> +               (("install\\(FILES cmake-mode.el \
>> +DESTINATION \\$\\{CMAKE_DATA_DIR\\}/editors/emacs\\)") ""))))
>
> Nitpick: I'd use a regexp to match the text following cmake-mode.el on
> the line to make it more resilient to any future changes. Otherwise this
> LGTM :)

Agree, pushed as f037673c3133ae7453794f1f62eecebf9d06b092
and emacs-cmake-mode bbdf36666b82eae0a583d7124d8117801969570c

Oleg.

Attachment: signature.asc
Description: PGP signature


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]