--- Begin Message ---
|
Subject: |
[PATCH] gnu: clementine: Drop dependency on qtwebkit. |
|
Date: |
Mon, 13 Aug 2018 20:26:21 +0100 |
|
User-agent: |
mu4e 1.1.0; emacs 26.1 |
Hello guix!
I realised clementine wasn't building because qtwebkit isn't building
either. But, it turns out that while it's an optional dependency
according to CMakeList.txt, it isn't actually used anywhere in the
code. Here's a patch that removes qtwebkit from its inputs.
0001-gnu-clementine-Drop-dependency-on-qtwebkit.patch
Description: Text Data
Thanks!
Pierre
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#32431] [PATCH] gnu: clementine: Drop dependency on qtwebkit. |
|
Date: |
Wed, 15 Aug 2018 14:35:26 -0400 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Wed, Aug 15, 2018 at 07:57:07AM +0100, Pierre Langlois wrote:
> Ah yes, that's expected. when packaging this we agreed not to add any of
> the gst-plugins-{good,bad,ugly} to the inputs and let the user install
> what they want instead [0]. Although, while we defenetely shouldn't add
> 'bad' and 'ugly', I don't see any reason not to add 'good' to make sure
> it all works out of the box. But then, the dialog hints the user should
> install them so that's not so bad as it is.
>
> Basically, I don't mind either way :-).
Previously, MP3 decoding in GStreamer was in gst-plugins-ugly because
MP3 was patented, but the patents expired and now gst-plugins-good
includes MP3.
I think the package should work as-is for its primary use case (music
playback), so I pushed your patches and also added gst-plugins-good and
gst-libav, ending with commit 8473f8024ceb8e7249702289b206782de7d4c71c.
signature.asc
Description: PGP signature
--- End Message ---