--- Begin Message ---
|
Subject: |
sed-4.3: testsuite/runtest does not check for a program extension |
|
Date: |
Sat, 21 Jan 2017 15:42:39 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.2.13) Gecko/20101206 SUSE/3.1.7 Thunderbird/3.1.7 |
OFYI, the testsuite/runtest shell script makes the assumption that programs
like get-mb-cur-max and test-mbrtowc have no extension but this is not true
for non-posix systems like Windows (aka MinGW) or MSDOS (aka DJGPP). Thus
the check fails when runtest is invoked. In some way the possibility for
an extension should be provided. The patch below is not intended as fix,
it shall only demonstrate the issue. It is clear that this problem cannot
be reproduced on a posix system like linux.
This means that the test fails to find programs if they have an extension
like ".exe" as used to be in DOS/Windows.
Regards,
Juan M. Guerrero
diff -aprNU5 sed-4.3.orig/testsuite/runtest sed-4.3/testsuite/runtest
--- sed-4.3.orig/testsuite/runtest 2016-07-25 03:03:56 +0000
+++ sed-4.3/testsuite/runtest 2017-01-13 17:49:42 +0000
@@ -9,11 +9,11 @@
: ${SED="./sed/sed"}
makefile="${abs_top_srcdir}/testsuite/Makefile.tests"
# Strip the directory './testsuite/' from the test name.
-test=`echo "$@"| sed 's,.*/,,'`
+test=`echo "$@"| sed 's,.*/,,;s,\.exe$,,'`
# Skip the utility programs, they are not standalone tests
test "$test" = get-mb-cur-max \
|| test "$test" = test-mbrtowc \
&& exit 77
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#25501: sed-4.3: testsuite/runtest does not check for a program extension |
|
Date: |
Tue, 9 Oct 2018 06:53:05 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
tags 25501 fixed
stop
Hello,
On 21/01/17 07:42 AM, Juan Manuel Guerrero wrote:
OFYI, the testsuite/runtest shell script makes the assumption that programs
like get-mb-cur-max and test-mbrtowc have no extension but this is not true
for non-posix systems like Windows (aka MinGW) or MSDOS (aka DJGPP).
Thank you for the report.
In the time since your bug report, sed's testsuite has
been greatly improved, and the problematic file (runtest)
has been completely removed:
https://git.savannah.gnu.org/cgit/sed.git/commit/?id=7daa26d068e5e84eed1212e203c2ce79c074604c
I've just tested the latest git revision on cygwin
and the auxiliary test files (get-mb-cur-max.exe and test-mbrtowc.exe)
are executed correctly.
As such I'm closing this bug report.
regards,
- assaf
--- End Message ---