emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#33386: closed (Gajim plugins)


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#33386: closed (Gajim plugins)
Date: Tue, 11 Dec 2018 10:23:01 +0000

Your message dated Tue, 11 Dec 2018 11:22:14 +0100
with message-id <address@hidden>
and subject line Re: [bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix 
packaged plugins.
has caused the debbugs.gnu.org bug report #33386,
regarding Gajim plugins
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33386: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33386
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Gajim plugins Date: Wed, 14 Nov 2018 20:54:38 +0100 User-agent: mu4e 1.0; emacs 26.1
Hi,

The first patch allow one to package Gajim plugins.  It also removes two
inputs that were added for the OMEMO plugin.

The second add the OMEMO plugin.

Thanks,
Clément



--- End Message ---
--- Begin Message --- Subject: Re: [bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins. Date: Tue, 11 Dec 2018 11:22:14 +0100 User-agent: mu4e 1.0; emacs 26.1
Clément Lassieur <address@hidden> writes:

> Danny Milosavljevic <address@hidden> writes:
>
>> Hi Clément,
>>
>>> I don't understand what this means.
>>> > I thought one can use any number of profiles - and this patch could
>>> > definitely pick from the wrong one.  
>>> 
>>> What do you mean?  This patch just adds the Guix packaged plugins to the
>>> list of plugin dirs.
>>
>> guix supports any number of profiles as one user, the ~/.guix-profile one is 
>> just
>> the default, you can create and select profiles at will.
>>
>> You can specify any profile you want using the option "-p" to "guix package" 
>> -
>> also, "guix environment" will create a custom profile.
>>
>> However, your patch hardcodes ~/.guix-profile which is in general not what a 
>> user
>> using "-p" would want.  I agree that it makes sense to search for the 
>> plugins in
>> the current profile, but it's not clear to me that ~/.guix-profile is always
>> guaranteed to BE the current profile.  Is it?
>>
>> According to 
>> https://www.gnu.org/software/guix/manual/en/html_node/Invoking-guix-environment.html#FOOT16
>>  ,
>> fontconfig already hardcodes ~/.guix-profile and "guix environment" has a
>> special flag to fake it, so maybe (probably?) it's OK to use it after all.
>>
>> I hope someone else can chime in - but this is what immediately caught my
>> eye because what's the use of all these environment variables if one
>> hard-codes ~/.guix-profile anyway - could have hard-coded it in all packages,
>> then...
>
> Understood, thanks for this nice explanation!
>
> I attached a new patch.  What do you think?

I pushed it.  I'll be happy to improve it if you have other comments.

Thanks,
Clément


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]