emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#53395: closed (Fix pypi import for flake8-array-spacing)


From: GNU bug Tracking System
Subject: bug#53395: closed (Fix pypi import for flake8-array-spacing)
Date: Wed, 26 Jan 2022 15:22:02 +0000

Your message dated Wed, 26 Jan 2022 16:20:52 +0100
with message-id <87ee4uh6az.fsf@gnu.org>
and subject line Re: bug#53395: Fix pypi import for flake8-array-spacing
has caused the debbugs.gnu.org bug report #53395,
regarding Fix pypi import for flake8-array-spacing
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
53395: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53395
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: Fix pypi import for flake8-array-spacing Date: Thu, 20 Jan 2022 20:45:19 +0100
Dear guix,

flake8-array-spacing is a funny package because its download URI uses a
base name of flake8_array_spacing. Apparently some other packages have
similar features, appearing as the downcase version.

What do you think?

Best regards,

Vivien

Attachment: 0001-pypi-importer-Convert-to-_-in-pypi-urls-if-needed.patch
Description: Fix the pypi importer

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- Subject: Re: bug#53395: Fix pypi import for flake8-array-spacing Date: Wed, 26 Jan 2022 16:20:52 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
Hi,

Vivien Kraus <vivien@planete-kraus.eu> skribis:

> From 8792367617d288e584a703db38c82c749a067c26 Mon Sep 17 00:00:00 2001
> From: Vivien Kraus <vivien@planete-kraus.eu>
> Date: Thu, 20 Jan 2022 20:11:56 +0100
> Subject: [PATCH] pypi importer: Convert - to _ in pypi urls if needed.
>
> * guix/import/pypi.scm (find-project-url): New function.
> (make-pypi-sexp): Use find-project-url.
> * tests/pypi.scm ("Package Foo has a correct pypi-uri of foo"): New test.
> ("If the package goo is released as foo, the importer warns"): New test.

\o/

I took the liberty to remove the integration tests you had added, I
think it’s preferable (especially since there’s a patch refactoring
these bits that Maxime submitted recently…).  I mentioned the other
changes to the commit log and added a copyright line for you.

Let me know if I got anything wrong.

Thank you!

Ludo’.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]