[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: compiler warnings for regex.c
From: |
Stefan Monnier |
Subject: |
Re: compiler warnings for regex.c |
Date: |
Fri, 27 Oct 2000 09:17:08 -0400 |
> > From: "Stefan Monnier" <monnier+gnu/address@hidden>
> > Date: Thu, 26 Oct 2000 09:59:51 -0400
> >
> > > /project/mule/fsf-emacs/lib-src/../src/regex.c:5584: warning:
> > > initialization discards qualifiers from pointer target type
> > >
> > > Are they harmless?
> >
> > No, they are not, which is why they're there.
> > They mean that re_match is not reentrant.
>
> Sorry, I don't understand. Why do we need to see a warning to know
> that re_match is non-reentrant?
Because re_match *should* be reentrant.
It doesn't matter for Emacs but it does matter in general.
> I think there should be no warnings during normal compilation.
> Warnings should be taken care of,
Adding a cast to hide the bug is not what I call "taking care of".
OTOH, really taking care of this problem will take some time.
Stefan