extern for variables defined in the same file?

[Pavel Janík]

Hi,

in xdisp.c we have something like this:

,----
| ...
| Lisp_Object Qmargin;
| ...
| static int
| single_display_prop_string_p (prop, string)
|      Lisp_Object prop, string;
| {
|   extern Lisp_Object Qwhen, Qmargin;
| ...
| }
| ...
| static int
| display_prop_string_p (prop, string)
|      Lisp_Object prop, string;
| {
|   extern Lisp_Object Qmargin;
| ...
`----

The variable Qmargin is defined only in this file and is not referenced in
any other file. Is the proper fix here to simply remove mentioned lines
beginning with extern? Or is there any reason to use extern here? If we
declare the variable as local we shadow its global value, but why we use
extern here? Maybe in the past, this variable was defines elsewhere
(xfaces.c) and this remained? Is it safe to delete it?
-- 
Pavel Janík

UNIX is basically a simple operating system, but you have to be a genius to
understand the simplicity.
                  -- Dennis Ritchie