emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Confusing naming of fringe i C-code


From: Richard Stallman
Subject: Re: Confusing naming of fringe i C-code
Date: Tue, 13 Nov 2001 16:00:00 -0700 (MST)

    So far, I've come across several different names for the fringes:

    `fringe' is primarily used on user visible symbols,

    `bitmap' is used without explicit reference to the fringe, e.g. 
bitmap_type, x_draw_bitmap, ...   
    This isn't wrong, but it would be clearer to use fringe_bitmap_type,
    x_draw_fringe_bitmap, etc.

The name bitmap_type seems reasonable, but x_draw_bitmap should be
renamed to x_draw_fringe_bitmap.

    `bitmap area' is used in several comments, as well as in 
BITMAP_AREA_FACE_ID (= fringe face)

It would be good to rename that, too.

    `flags area' seems to be the favourite term throughout the code, e.g.
    FRAME_FLAGS_AREA_WIDTH, FRAME_X_RIGHT_FLAGS_AREA_WIDTH, flags_areas_extra, 
...

Is "flags area" in fact a synonym for "fringe"?  If so, it would be good
to rename these names too.

    And then there are the mixed forms FRAME_FLAGS_BITMAP_WIDTH and 
FRAME_FLAGS_BITMAP_HEIGHT.

Those names refer to the size of the bitmaps that are drawn in the
fringe, so they should be left unchanged.


Would you like to do it?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]