Re: Reported bad code in Emacs configure file

[Jim Meyering]

That code comes from configure.in:

dnl Check for speed_t typedef.
AC_CACHE_CHECK(for speed_t, emacs_cv_speed_t,
AC_TRY_COMPILE([#include <termios.h>], [speed_t x = 1;],
  emacs_cv_speed_t=yes, emacs_cv_speed_t=no))
if test $emacs_cv_speed_t = yes; then
  AC_DEFINE(HAVE_SPEED_T, 1, [Define to 1 if `speed_t' is declared by 
<termios.h>.])
fi

Since that variable is defined either to no or to yes just above
(in the absence of a cached value), I don't see a need for double
quotes, unless he's doing something strange:

  -- he is using a corrupted cache file, or
  -- he has set emacs_cv_speed_t to the empty string in his environment

...
> *** configure.~1~       Fri Mar 15 06:46:09 2002
> --- configure   Tue Apr 30 13:26:28 2002
> ***************
> *** 3039,3045 ****
>   fi
>
>   echo "$ac_t""$emacs_cv_speed_t" 1>&6
> ! if test $emacs_cv_speed_t = yes; then
>     cat >> confdefs.h <<\EOF
>   #define HAVE_SPEED_T 1
>   EOF
> --- 3039,3045 ----
>   fi
>
>   echo "$ac_t""$emacs_cv_speed_t" 1>&6
> ! if test "$emacs_cv_speed_t" = yes; then
>     cat >> confdefs.h <<\EOF
>   #define HAVE_SPEED_T 1
>   EOF