Re: Patch for Emacs X focus issue

[Stefan Monnier]

> The patch is attached below.  Please comment, and if it is OK, I will
> commit it into CVS.

I have no idea about the actual focus handling issue in X, but I'm
surprised by the first hunk in your patch (see below), which seems
unrelated.  What is the reason for it ?


        Stefan


> Index: src/keyboard.c
> *** src/keyboard.c.~1.683.~   2002-06-22 16:17:17.000000000 +0200
> --- src/keyboard.c    2002-06-23 19:21:07.000000000 +0200
> ***************
> *** 3259,3285 ****
>     if (do_timers_now)
>       timer_check (do_timers_now);
>   
> -   /* If the buffer contains only FOCUS_IN_EVENT events,
> -      report it as empty.  */
>     if (kbd_fetch_ptr != kbd_store_ptr)
> -     {
> -       struct input_event *event;
> - 
> -       event = ((kbd_fetch_ptr < kbd_buffer + KBD_BUFFER_SIZE)
> -            ? kbd_fetch_ptr
> -            : kbd_buffer);
> - 
> -       while (event->kind == FOCUS_IN_EVENT)
> -     {
> -       event++;
> -       if (event == kbd_buffer + KBD_BUFFER_SIZE)
> -         event = kbd_buffer;
> -       if (event == kbd_store_ptr)
> -         return 0;
> -     }
>         return 1;
> -     }
> - 
>   #ifdef HAVE_MOUSE
>     if (!NILP (do_mouse_tracking) && some_mouse_moved ())
>       return 1;
> --- 3259,3266 ----