[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Support for case sensitive abbrev expansion
From: |
Károly Lőrentey |
Subject: |
Re: [PATCH] Support for case sensitive abbrev expansion |
Date: |
Fri, 26 Jul 2002 18:21:17 +0200 |
User-agent: |
Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.3.50 (i686-pc-linux-gnu) |
Miles Bader <address@hidden> writes:
> There's no need to add a new field to `struct buffer' for the
> `abbrev-case-fold' variable, you can just declare a normal variable
> Vabbrev_case_fold using DEFVAR_LISP, and emacs will do the right thing
> if a mode makes it buffer-local. [There are obviously trade-offs, but I
> think for something minor like this you shouldn't extend the buffer
> structure]
You are right, and I was hoping for a solution that was simpler than
that. :-)
> The feature that makes it track `case-fold-search' probably isn't useful
> -- I expect that in most cases people will want to retain
> case-insensitive searching, even in situations where case-sensitive
> abbrevs would be appropriate. I think you should just initialize the
> global value to `nil' for compatibility, and leave it to individual
> language modes to set a different buffer-local value.
All right. Here is a much cleaner patch:
abbrev.2.patch
Description: Case-sensitive abbrev expansion, v2
2002-07-26 Károly Lőrentey <address@hidden>
* abbrev.c (Vabbrev_case_fold): New variable.
(Fexpand_abbrev): Use it.
(Fdefine_global_abbrev, Fdefine_mode_abbrev): Do not downcase
abbrev.
(syms_of_abbrev): Initialize Vabbrev_case_fold.
2002-07-26 Károly Lőrentey <address@hidden>
* cus-start.el: Added abbrev-case-fold.
--
Lőrentey Károly