Re: `eshell-under-cygwin-p' etc. inappropriate?

[John Wiegley]

>>>>> On Tue Aug  6, John writes:

> This was a patch I suggested for the eshell XEmacs package. I'm not
> certain it is appropriate for XEmacs, but I don't think it should
> have been installed in Emacs.  I thought it had been rejected,
> rightly.

That's odd; I thought we had agreed to check them in.  Why should the
XEmacs version diverge from Emacs?  Emacs runs under cygwin also.

> Furthermore, `eshell-under-cygwin-p' is a misleading name: it should
> probably be `eshell-under-xemacs-cygwin-p' or similar.

Why?

> I don't understand why these changes were installed now, four months
> after they were suggested.

If you want them removed, I will remove them.  It's been four months
because that's how long it's taken me to get back to my Emacs work.

John