|
| From: | Stefan Monnier |
| Subject: | Re: [patch] cache color info for remote X sessions [Was: Emacs 21/X11 generating unbelieveable network traffic] |
| Date: | Mon, 07 Oct 2002 10:53:52 -0400 |
> - The keys were being xmalloc'ed (unnecessarily) and then leaked. Instead
> each of the wrapper functions now has a static buffer (of a #define'able
> size) to store the transient keys.
Yuck! At least use alloca. Disallowing re-entrance is always a bad idea.
By the way, is the cached answer always the same as the one we would have
goten without the cache ? IF not, what is the potential impact ?
Can/should we invalidate the cache sometimes to avoid/reduce those
problems ?
Stefan
| [Prev in Thread] | Current Thread | [Next in Thread] |