[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Mule-UCS 0.84 (KOUGETSUDAI) release.
From: |
Andreas Schwab |
Subject: |
Re: Mule-UCS 0.84 (KOUGETSUDAI) release. |
Date: |
Thu, 05 Dec 2002 13:16:17 +0100 |
User-agent: |
Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.3.50 (ia64-suse-linux) |
Kenichi Handa <address@hidden> writes:
|> In article <address@hidden>, Andreas Schwab <address@hidden> writes:
|> > IMHO this patch is better:
|>
|> > --- mucs.el 2002/12/05 10:43:28 1.1
|> > +++ mucs.el 2002/12/05 10:46:26
|> > @@ -196,7 +196,7 @@ In order to embed data or lisp code, use
|> > (funcall (car hookval))
|> > result)
|> > hookval (cdr hookval)))
|> > - (cons 'progn
|> > + (list 'progn
|> > result)))
|>
|> > (defmacro mucs-define-package (package &rest form)
|>
|> Could you explain why?
Actually this is also wrong. The right fix is to collect the function
results with cons instead of append. Each hook function is returning a
form to be evaluated, and the final form returned by the macro is
supposed to be one that evaluates each form in sequence.
--- mucs.el 2002/12/05 10:43:28 1.1
+++ mucs.el 2002/12/05 12:15:29
@@ -192,7 +192,7 @@ In order to embed data or lisp code, use
(if (not (listp hookval))
(error "Invalid hook:%S" hooksym)))
(while hookval
- (setq result (append
+ (setq result (cons
(funcall (car hookval))
result)
hookval (cdr hookval)))
Andreas.
--
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
Re: Mule-UCS 0.84 (KOUGETSUDAI) release., Kenichi Handa, 2002/12/05
Re: Mule-UCS 0.84 (KOUGETSUDAI) release., 宮下 尚:HIMI, 2002/12/05