[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHES] 21.3.50 for Cygwin: patch 5
From: |
Eli Zaretskii |
Subject: |
Re: [PATCHES] 21.3.50 for Cygwin: patch 5 |
Date: |
Wed, 25 Dec 2002 08:12:45 +0200 (IST) |
On Fri, 6 Dec 2002, Joe Buehler wrote:
> --- lib-src/pop.c 17 May 2002 11:24:02 -0000 1.31
> +++ lib-src/pop.c 6 Dec 2002 16:34:43 -0000
> @@ -119,6 +119,9 @@
> #endif
> #endif
>
> +#ifdef _P
> +#undef _P
> +#endif
> #ifndef _P
> # ifdef __STDC__
> # define _P(a) a
This might be dangerous: other platforms could define _P in their system
header, and this patch then causes them to use the definition supplied by
pop.c. If that definition somehow doesn't work on some of those
platforms, pop.c is now broken on them.
In other words, this change has effect much beyond the Cygwin port, and
should IMHO be avoided if possible.
Why isn't the original #ifndef guard enough to solve the problem on
Cygwin? Could you please show how does the original code fail, and
explain why?
> --- src/mem-limits.h 19 Aug 2002 17:45:50 -0000 1.31
> +++ src/mem-limits.h 6 Dec 2002 16:35:33 -0000
> @@ -46,6 +46,10 @@
> #define BSD4_2
> #endif
>
> +#ifdef CYGWIN
> +#define BSD4_2
> +#endif
Can't this be done in src/s/cygwin.h?