Re: strange change in store_symval_forwarding (data.c)

[Andreas Schwab]

Kenichi Handa <address@hidden> writes:

|> Currently, store_symval_forwarding has this code:
|> 
|>      case Lisp_Misc_Buffer_Objfwd:
|>        {
|>          int offset = XBUFFER_OBJFWD (valcontents)->offset;
|>          Lisp_Object type;
|> 
|>          if (! NILP (type) && ! NILP (newval)
|>              && XTYPE (newval) != XINT (type))
|>            buffer_slot_type_mismatch (offset);
|> 
|> Please note that the local variable `type' is used without
|> being initialized.
|> 
|> Previously, the code has this initilization part:
|> 
|>          Lisp_Object type;
|> 
|>          type = PER_BUFFER_TYPE (offset);
|>          if (XINT (type) == -1)
|>            error ("Variable %s is read-only", SDATA (SYMBOL_NAME (symbol)));
|> 
|> ChangeLog doesn't say anything about this change, but it
|> seems that it was done when this change was installed.
|> 
|> 2003-03-13  Andreas Schwab  <address@hidden>
|> [...]
|>      * data.c (long_to_cons): Fix type of top.
|> 
|> Andreas, do you know somthing about it?

This code was already like this in revision 1.219, ie. before my change.

Andreas.

-- 
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."