emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: building directory


From: Richard Stallman
Subject: Re: building directory
Date: Sat, 05 Apr 2003 03:12:17 -0500

That is a good hack.  As someone pointed out, it needs to cope with
the situation that the sources are not present in the specified
directory.

The suggestion that you should search through the file rather than
just go to the recorded line number is important.

A few other little changes are called for.

         { PVEC_SUBR | (sizeof (struct Lisp_Subr) / sizeof (EMACS_INT)),        
\
    -      fnname, minargs, maxargs, lname, prompt, 0};                 \
    +      fnname, minargs, maxargs, lname, prompt, 0, __FILE__, 
(short)__LINE__}; \

    +DEFUN ("source-line", Fsource_line, Ssource_line, 1, 1, 0,

Please call it `function-source-line'.  Likewise for 
`function-source-file'.

    +    return make_number((EMACS_INT)XSUBR(fun)->src_line);

Please write a space before the first openparen.

    +  "Path specifying the place where emacs C source files are.

In the GNU conventions, we don't use the term "path" this way.
Please say "Directory for visiting the Emacs C source files."





reply via email to

[Prev in Thread] Current Thread [Next in Thread]