Re: [Bug] Issues with format.el: coding system, byte/char confusion

[Richard Stallman]

     1. Shouldn't `format-annotate-function' also save the buffer-local
        variable `buffer-file-coding-system' (as it does with
        `selective-display' and `enable-multibyte-characters' since v1.38)?

That seems plausible, but one ought to test it.

     2. To compute the coding system of the current buffer, Emacs adds
        function `after-insert-file-set-buffer-file-coding-system' to
        `after-insert-file-functions'.  Is this correct?

Yes.

         - decode functions using format.el,
         - decode functions in `after-insert-file-functions' before
           `after-insert-file-set-buffer-file-coding-system',
         - Emacs determines the coding system with
           `after-insert-file-set-buffer-file-coding-system',
         - decode functions in `after-insert-file-functions' after
           `after-insert-file-set-buffer-file-coding-system'

That would be true, if there is anything in
after-insert-file-functions other than
after-insert-file-set-buffer-file-coding-system.  Normally I believe
there isn't anything else.

        I would assume that the coding system must be determined before any
        of the decode functions have been executed...

Not necessarily.  That would depend on what those other functions are.
Normally there aren't any others.  I suppose if you add other functions
to this hook that you should put them in the proper order.

Is there any real example where this question arises, or is it
purely hypothetical.

     3. The docstring of `after-insert-file-functions' includes "It should
        return the new byte count", whereas `format-decode' returns the
        new char count.

It looks like they are really both measured in characters.
I will fix some doc strings.

Thanks.