Miles' patch still fixes xfaces.c

[Robert J. Chassell]

The recent change to xfaces.c has not fixed the problem that
no one can permanently change
        :weight bold 
to
        :weight normal
in the variable `mode-line-buffer-identification', which is
buffer-local and in other places.

As far as I know, this problem resulted from a change on 19 Nov 2002
in mode-line-buffer-identification

(Several other bugs also appeared at the same time.)

Although the bug does not look too bad with a plain vanilla instance
of Emacs, with an `10x20' font, 
    -Misc-Fixed-Medium-R-Normal--20-200-75-75-C-100-ISO8859-1
the new bold creation technique fills in letters such as `m'
so that they become unreadable rectangles.

The word `Emacs' becomes unreadable.

Fortunately, Miles Bader posted a semi-fix on 18 Dec 2002.  This was a
`semi-fix' because his code sometimes led to a race condition and a
crash in Emacs.  But not very often.

Mile's patch is

    diff -u -r1.266 xfaces.c
    --- src/xfaces.c    17 Nov 2002 23:51:19 -0000      1.266
    +++ src/xfaces.c    18 Dec 2002 05:26:34 -0000

and works with the new version of xfaces.c, version 1.277 
(CVS from 2003 May 26 23:00 UTC)

However, it would be nice to see a clean fix to this problem, which is
to be able to specify any characteristic for `bold', including a
color, and including being able to set the weight of something that is
`bold' to `normal'.

The old messages are: 

    Bold by moving pixels problem
    starting on 20 Nov 2002

    signal handling bogosities
    starting on 19 Dec 2002

The patch is from 

    From: Miles Bader <address@hidden>
    Subject: Re: Bold by moving pixels problem
    Date: 18 Dec 2002 19:01:01 +0900

Thanks!

-- 
    Robert J. Chassell                         Rattlesnake Enterprises
    http://www.rattlesnake.com                  GnuPG Key ID: 004B4AC8
    http://www.teak.cc                             address@hidden