Re: recent emacs font problems?

[Kim F. Storm]

Reading through the case and the comments, and comparing this to the
code, I'm uncertain whether the intention of the fix is to _only_
avoid overriding the :family property (that's not what the fix does,
but what the comment below says), or whether the intention really is
to avoid overriding any of the properties (as the fix does).

If the intention is only to avoid overriding :family, then we could
pass -1 for FORCE_P and test explicitly for force_p > 0 in
set_lface_from_font_name in connection with the :family property.


Richard Stallman <address@hidden> writes:

>     Is this the right fix (not properly tested) ?
> 
>     --- /build/emacs/src/xfaces.c.~1.277.~    Wed May 28 06:00:50 2003
>     +++ /build/emacs/src/xfaces.c     Wed May 28 06:10:40 2003
>     @@ -6584,9 +6584,7 @@
>          frame_font = Fassq (Qfont, f->param_alist);
>          xassert (CONSP (frame_font) && STRINGP (XCDR (frame_font)));
>          frame_font = XCDR (frame_font);
>     -      /* Specify 0 for FORCE_P here, so that we don't override
>     -  a :family attribute specified for `default' for new frames.  */
>     -      set_lface_from_font_name (f, lface, frame_font, 0, 1);
>     +      set_lface_from_font_name (f, lface, frame_font, 1, 1);
>        }
>      #endif /* HAVE_WINDOW_SYSTEM */
> 
> That is not correct.  It would bring back a bug I fixed recently.  I
> think it was the following bug.
> 
> 
> Date: Thu, 15 May 2003 09:59:01 +0200 (CEST)
> From: Klaus Straubinger <address@hidden>
> To: address@hidden
> 
> If the font family of the default face is changed with
> (set-face-attribute 'default nil :family "fixed")
> then this does not change the face's font for subsequent frames, as can
> be seen with the evaluation of (face-font 'default) in the first frame
> and in a second, created with C-x 5 2, respectively.
> 
> I found that that call to set_lface_from_font_name was
> clobbering the family that had come from the new-frame default.
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/emacs-devel
> 
> 

-- 
Kim F. Storm <address@hidden> http://www.cua.dk