emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Invisible colons in Emacs Info.


From: Stefan Monnier
Subject: Re: Invisible colons in Emacs Info.
Date: Mon, 07 Jul 2003 10:47:54 -0400

> So, in other words, the importance of putting a space after the first
> Mtools is really to make clear that this is where the real subtopic
> name ends.  The reason why Karl and me would like to insist on the
> space after the final colon is not: "Because we tell so!", but to make
> clear that the final colon is really the final colon and to avoid
> confusion in cases like this one.

I don't know what makes you think that this hasn't been clear, but
just in case: yes we all agree about that (including the regexp, AFAIK).

> Actually, let us take a look at the actual menu entry which does have
> the space we want:
> 
> * Mtools: (mtools).        Mtools: utilities to access DOS disks in Unix.
> 
> I do not know whether you have this entry and hence can check the
> following:
> 
> Put the cursor on that line and do `m'.
> 
> Look at the echo area:

Nitpick: this is not the echo area but the minibuffer.
The reason why I'm nitpicking here is because you also referred to the echo
area in the other email and I thought you were referring the help-echo
property (which is the only thing appearing in the echo area).

> Menu item (default Mtools: (mtools).        Mtools):

It looks like a bug due to the fact that this part of the code had its
own idea of what is a valid menu entry name.  The bug was
introduced several months ago along with the patch that allowed `:'
in menu entries.  See patch below.


        Stefan


--- info.el.~1.364.~    Sun Jul  6 13:01:11 2003
+++ info.el     Mon Jul  7 10:44:54 2003
@@ -1652,7 +1652,9 @@
            (save-excursion
              (goto-char p)
              (end-of-line)
-             (if (re-search-backward "\n\\* +\\([^\t\n]*\\):" beg t)
+             (if (re-search-backward (concat "\n\\* +\\("
+                                             Info-menu-entry-name-re
+                                             "\\):") beg t)
                  (setq default (match-string-no-properties 1))))))
      (let ((item nil))
        (while (null item)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]