Re: extensions for emacsclient (CVS version)

[Andreas Büsching]

Hi,

Miles Bader <address@hidden> wrote:

> Andreas Büsching <address@hidden> writes:
>> -    sprintf (server.sun_path, "/tmp/emacs%d-%s/server", (int) geteuid (), 
>> system_name);
>> +    sprintf (server.sun_path, "%s", socket_name);
>> +    sprintf (server.sun_path, "/tmp/emacs%d-%s/server", (int) geteuid (), 
>> system_name);
>
> Hmmm, no bounds checking when writing into server.sun_path (the old code
> didn't either, but the constructed path is probably less likely to
> overflow).

If this is the only problem that is simple to fix! So we will replace
'sprintf(' with 'snprintf( sizeof server.sun_path, '. Is that what you
mean?

crunchy

-- 
Hard work never killed anyone, but why give it a chance?