Re: bug in save-some-buffers or diff.el?

[Juri Linkov]

David Abrahams <address@hidden> writes:
> Juri Linkov <address@hidden> writes:
> > David Abrahams <address@hidden> writes:
> >> Here's my backtrace:
> >> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
> >>   expand-file-name(nil)
> >>   find-file-noselect(nil)
> >>   diff-parse-differences(732 nil)
> >
> > This bug is already fixed and yesterday checked in to CVS (files
> > compile.el and diff.el).  This bug was caused by setting the variable
> > `compile-auto-highlight' to t.  Now it is nil by default.
> > However, even if you set it back to t, it will not cause the same bug,
> > because function `diff-parse-differences' now is changed not to
> > call the `find-file-noselect' at all.
> 
> Well, the problem was repro'd in a version of emacs built yesterday
> at approx. 5pm EST, and neither of those two files has changed since
> I did my checkout.  I appear to have both changes, as well.
> 
> Hmm, maybe I need to do 
> 
>   nmake recompile && nmake install 
> 
> in the lisp directory?  It surprises me that 
> 
>    nmake && nmake install
> 
> from the nt directory is insufficient after updating my local CVS
> image.

Your backtrace indicates that you use older version of diff.el, because
newest version have no `find-file-noselect' function call at all.
I can't tell how to recompile .el files under Windows, but it's clear
that your .elc files are older than fixed .el files.

BTW, I'm sure that current behavior of `load' is wrong.  It always
tries to load .elc file first, even if it's older than .el.  But often
it causes too much trouble after updating .el files.  There are many
reasons why this happens: user forgets to recompile updated .el files,
something goes wrong in the make process, etc.  Yes, `load' reports
a warning, but usually this warning goes unnoticed, which results in
broken functionality.  Instead, `load' should load the newest of .el
or .elc files, and report the same warning as a simple reminder to
recompile updated .el files to execute them faster.

-- 
http://www.jurta.org/emacs/