Re: Drag and drop patch for X, please review.

[Jan D.]

> It is good that you could implement this mostly in Lisp;
> that makes it easier to customize and adapt.
> Thanks for improving the doc strings.
>
> Could you put a blank line between a function definition
> and the preceding comment?

Yes.

> If the user drops an icon representing a file into a Dired buffer,
> I think it should rename or copy the file into that directory.
> That is what drag-and-drop was used for originally on
> the Mac: to move files between directories.  But I don't
> see any code here to do rename or copy.

If we know the target is a dired buffer, we can then accept the
action that the source sends us (XdndActionCopy or XdndActionMove)
instead of always using XdndActionPrivate and to the right thing
for each action.

> Does the current protocol handle dragging and dropping of files in any
> way?  I don't see anything in x-dnd-known-types for files.

The types text/uri-list, text/x-moz-url, FILE_NAME and _NETSCAPE_URL all
can have file:// URLs.  text/uri-list is the one XDND and the 
freedesktop
organization wants everybody to use.  text/x-moz-url is used by mozilla
and newer netscape.  FILE_NAME is used by the OpenWindows protocol (and
maybe older programs that don't do XDND, but Motif or OpenWindows),
_NETSCAPE_URL are older netscape (4.x and older).

So the file code is just handling the file:/// URLs.

        Jan D.