emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: list-colors-display: filter same adjecent colors


From: Eli Zaretskii
Subject: Re: list-colors-display: filter same adjecent colors
Date: Sat, 06 Mar 2004 10:51:50 +0200

> Date: Fri, 5 Mar 2004 15:49:19 -0800 (PST)
> From: Michael Mauger <address@hidden>
> 
> How does this patch look:

It's okay with me, but I'd suggest to give an explicit example in
this comment:

> +    ;; Identify duplicate colors by the name rather than the color
> +    ;; value.  On w32, logical colors are added to the list that might
> +    ;; have the same value but have different names and meanings.
> +    ;; Detecting duplicates by name insures that all of these logical
> +    ;; colors remain despite similar color values.

I'd mention the special ``system'' colors and why they are important,
just so people could see a specific example.

Thanks.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]