Re: smtpmail.el and 1msg

[Simon Josefsson]

address@hidden writes:

>   > Do you have of a reference to this 1msg stuff?  
>
> http://groups.google.com/groups?hl=en&lr=&ie=UTF-8&oe=UTF-8&threadm=53a824b6.0402031144.54558593%40posting.google.com&rnum=30&prev=/groups%3Fq%3D1msg%26start%3D20%26hl%3Den%26lr%3D%26ie%3DUTF-8%26oe%3DUTF-8%26selm%3D53a824b6.0402031144.54558593%2540posting.google.com%26rnum%3D30
>
> Sorry about the long URL there, but I that thread was as close as I
> could find.  Basically, SBC came in and made some changes that aren't
> compatible with various mailers including Mozilla, Eudora, and Emacs
> smtpmail...  If I use smtpauth.sbcglobal.net and use AUTH LOGIN, I can
> send just fine and it waits for QUIT just like it's supposed to.  
>
> Ultimately, I suspect that other ISPs are going to use the 1msg option
> to help stop spammers.  *eyeroll* Not sure how it should be
> incorporated...  all I know for sure is that my patch Works For Me.
> ;-)

Thanks for the reference.  I'm not sure about your patch -- it appears
wrong to look for /1msg.  I think the right fix would be to fix the
code so that smtpmail.el doesn't hang forever waiting for response to
QUIT.  So it should work without detecting "/1msg".  Does this patch
help?  If not, can you pinpoint exactly where does smtpmail.el hang,
using (setq debug-on-quit t) and pressing C-g when it spins?

--- smtpmail.el.~1.65.~ 2004-02-11 13:34:59.000000000 +0100
+++ smtpmail.el 2004-03-10 23:50:06.000000000 +0100
@@ -1,6 +1,6 @@
 ;;; smtpmail.el --- simple SMTP protocol (RFC 821) for sending mail
 
-;; Copyright (C) 1995, 1996, 2001, 2002, 2003 Free Software Foundation, Inc.
+;; Copyright (C) 1995, 1996, 2001, 2002, 2003, 2004 Free Software Foundation, 
Inc.
 
 ;; Author: Tomoji Kagatani <address@hidden>
 ;; Maintainer: Simon Josefsson <address@hidden>
@@ -778,10 +778,12 @@
        (response-continue t)
        (return-value '(nil ()))
        match-end)
-
+    (catch 'done
     (while response-continue
       (goto-char smtpmail-read-point)
       (while (not (search-forward "\r\n" nil t))
+         (unless (memq (process-status process) '(open run))
+           (throw 'done nil))
        (accept-process-output process)
        (goto-char smtpmail-read-point))
 
@@ -817,10 +819,8 @@
            (setq smtpmail-read-point match-end)
            (setq response-continue nil)
            (setq return-value
-                 (cons nil (nreverse response-strings)))
-           )
-         )))
-    (setq smtpmail-read-point match-end)
+                   (cons nil (nreverse response-strings)))))))
+      (setq smtpmail-read-point match-end))
     return-value))