emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: More enhancements to fringe bitmaps.


From: Marco Munari
Subject: Re: More enhancements to fringe bitmaps.
Date: Wed, 17 Mar 2004 14:59:56 +0100
User-agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux)

[i saw you resend, this mail reply was not sent
 because it was "under construction"]

~\/~ "Miles" == Miles Bader <address@hidden> writes:

Miles> BTW, I notice that this patch makes `active fringes' the
Miles> distinguished case, and uses the normal fringe property for
Miles> `inactive fringes', which is the opposite of what happens with
Miles> modelines (the active modeline is `normal', and inactive ones
Miles> are special).

Miles> Is there a reason for this difference? 

i thought a reason, but with some my assumptions, i'm not sure if
is valid for you:
1- never change existing variable names expecially if related to
  customizable names unless really necessary
2- choose the name which maximixe the meaning when introducing new
  variable names.

i suppose the cronological history of this faces is:
+ modeline (aliased)
+ mode-line
+ mode-line-inactive
+ fringe

when i was partitioning the fringe face concept into active and inactive
meaning i was in dubt becouse  i suppose (1) i can't change existing names,

and in my mind "inactive" without express "active" is unexpected logic,
because "inactive" is etymologically a word which extents "active".
i didn't choose fringe-inactive by this opinion.


But now, in more conservative point of view i can find a reason to
imitate mode-line-inactive logic:
when existing(/previous) unique fringe face is whatched by the user,
the name is "fringe" and it is implicitly thoughts "active"
in current window, even if there was not distinction.


Anyway I temporary (locally) change the name in
 to fringe-active and fringe-inactive, and
put an alias fringe (put 'fringe 'face-alias 'fringe-active),
you can expect a new patch relative to the original emacs,
after i sign copyright disclaimer papers,

Anyway i have to say: in previous patch in xdisp.c there was wrong asignment
to Qfringe, the second assignment should be to Qfringe_active in previous
naming logic, and this explain the surprise noticed and commented
in the same file:
xfaces.c in line 7705
-  Qfringe = intern ("fringe-inactive");
+  Qfringe_active = intern ("fringe-active");
relative to that patch

actually i have connection timeout to port 22 of savannah.gnu.org

Miles> If not, it seems things might as well be consistent.


Miles> -miles -- "Whatever you do will be insignificant, but it is
Miles> very important that you do it."  Mahatma Ghandi


Saluti,
MARco
-- 
x(t),y(t) = th(3t-34.5)*e^[-(3t-34.5)^2]/2-4.3+e^(-1.8/t^2)/(.8*atg(t-
3)+2)(t-1.8)-.3th(5t-42.5),(1.4e^[-(3t-34.5)^2]+1-sgn[|t-8.5|-.5]*1.5*
|sin(pi*t)|^[2e^(-(t-11.5)^2)+.5+e^(-(.6t-3.3)^2)])/(.5+t)+1  ; 0<t<14




reply via email to

[Prev in Thread] Current Thread [Next in Thread]