Re: division of integers by floats

[Piet van Oostrum]

>>>>> Richard Stallman <address@hidden> (RS) wrote:

RS>     Here's a patch to put the change in the DEFUN.  Note that there is no
RS>     effective change for the two arg form, so its still efficient and there
RS>     wont be any "surprises" for the dominant usage.

RS> Your change is ok too.
RS> (Could someone install it, as a "tiny change"?)

RS> --- data.c      6 May 2004 00:10:15 -0000       1.237
RS> +++ data.c      6 May 2004 20:24:25 -0000
RS> @@ -2698,7 +2698,13 @@
RS>       int nargs;
RS>       Lisp_Object *args;
RS>  {
RS> -  return arith_driver (Adiv, nargs, args);
RS> +  int argnum;
RS> +  if (nargs == 2)
RS> +    return arith_driver (Adiv, nargs, args);
RS> +  for (argnum = 0; argnum < nargs; argnum++)
RS> +    if (FLOATP (args[argnum]))
RS> +      return float_arith_driver (0, 0, Adiv, nargs, args);
RS> +  return arith_driver (Adiv, nargs, args);
RS>  }

This can even be combined as:

+  int argnum;
+  for (argnum = 2; argnum < nargs; argnum++)
+    if (FLOATP (args[argnum]))
+      return float_arith_driver (0, 0, Adiv, nargs, args);
+  return arith_driver (Adiv, nargs, args);

-- 
Piet van Oostrum <address@hidden>
URL: http://www.cs.uu.nl/~piet [PGP]
Private email: address@hidden