Re: ChangeLog fontifications

[Sam Steingold]

> * Juri Linkov <address@hidden> [2004-05-11 21:03:03 +0300]:
>
> Sam Steingold <address@hidden> writes:
>> when ChangeLog records a change in a Common Lisp function with a
>> package prefix, only the package name is highlighted, not the function
>> name:
>>
>>      * foo.lisp (PACK:FUNCTION-NAME): optimized frobnifications
>>
>> "PACK" is highlighted but "FUNCTION-NAME" is not.
>>
>> I am pretty sure that `change-log-font-lock-keywords' in add-log.el
>> needs to be fixed, but I am not quite sure how...
>
> I see no harm in removing : from regexps of function names.  I don't
> understand why such restriction was added here, given the fact that
> parentheses around a function name already pretty safely enclose it.
>
> Index: lisp/add-log.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v
> retrieving revision 1.149
> diff -u -r1.149 add-log.el
> --- lisp/add-log.el   19 Apr 2004 11:31:05 -0000      1.149
> +++ lisp/add-log.el   11 May 2004 17:57:14 -0000
> @@ -230,13 +230,13 @@
>       ;; Possibly further names in a list:
>       ("\\=, \\([^ ,:([\n]+\\)" nil nil (1 'change-log-file-face))
>       ;; Possibly a parenthesized list of names:
> -     ("\\= (\\([^) ,:\n]+\\)" nil nil (1 'change-log-list-face))
> -     ("\\=, *\\([^) ,:\n]+\\)" nil nil (1 'change-log-list-face)))
> +     ("\\= (\\([^) ,\n]+\\)" nil nil (1 'change-log-list-face))
> +     ("\\=, *\\([^) ,\n]+\\)" nil nil (1 'change-log-list-face)))
>      ;;
>      ;; Function or variable names.
> -    ("^\t(\\([^) ,:\n]+\\)"
> +    ("^\t(\\([^) ,\n]+\\)"
>       (1 'change-log-list-face)
> -     ("\\=, *\\([^) ,:\n]+\\)" nil nil (1 'change-log-list-face)))
> +     ("\\=, *\\([^) ,\n]+\\)" nil nil (1 'change-log-list-face)))
>      ;;
>      ;; Conditionals.
>      ("\\[!?\\([^]\n]+\\)\\]\\(:\\| (\\)" (1 'change-log-conditionals-face))

that's what I first tried too, but it did not appear to work...
oh - looks like I need to reload the ChangeLog file itself!  cool!
please check this in!

Now, multiline entries are also handled incorrectly:


        * foo.lisp (aasfasdfffffffffffffffffffffffffffffffff,
        sadfggggggggggggg): ...




-- 
Sam Steingold (http://www.podval.org/~sds) running w2k
<http://www.camera.org> <http://www.iris.org.il> <http://www.memri.org/>
<http://www.mideasttruth.com/> <http://www.honestreporting.com>
Why do we want intelligent terminals when there are so many stupid users?