Re: Last change to process.c breaks fetching pop3 mail (gnus/pop3.el)

[Noah Friedman]

>I have very severe problems fetching mail from my POP3 mailboxes after
>the following change was installed:
>
>2004-05-28  Noah Friedman  <address@hidden>
>
>       * process.c (Fdelete_process): Do not call remove_process.
>
>In essense, Gnus manages to fetch one or two articles and then it stalls,
>in some loop with accept-process-output and searching for \r\n in the buffer.
>
>Undoing the above change makes it work again.
>
>What (real world) problem was that change supposed to fix ?
>
>Probably it must be fixed in another way that doesn't break existing code.

Damn.  I thought I had checked fairly carefully that nothing would be
affected since the call to remove_process happens anyway eventually.

I left a comment in the source that explained why I removed the call.  In
summary, calling remove_process there does 2 things wrong:

  (1) network process objects are removed from Vprocess_alist even if
      delete-exited-processes is nil
  (2) network processes never have their sentinel called a final time

Fdelete_process is called for network processes via kill_buffer_processes,
so the mechanics of cleaning up network processes is different than for
child processes, which are just signalled.